Defects in ConvertToQ3DdE

[Andrei Savici]

The transformation from Qlab to HKL is not HKL = Goniometer * UB * q_lab_frame It is either q_lab_frame = Goniometer * UB * HKL or q_lab_frame = 2*Pi*Goniometer * UB * HKL. You need to specify the convention in the wiki. Also, I created an array length validator. You can use that to check that you use 4 QminEmin and 4 QmaxEmax values.

[Alex Buts]

refs #4091 fixing unix warnings

Changeset: d59a9193f1b875f9d8e3f10cd088ee462e6dba87

[Alex Buts]

refs #4091 Fing Unix warning (stupid sctipt wants longer message)

Changeset: a4905d6724db5c444e4635bcce04f685569af2ab

[Alex Buts]

refs #4091 Fixing Unix warning

Changeset: b6ed441233229eabe4de54a228eed95adcc5140f

[Andrei Savici]

Fixed logical errors in OrientedLattice. Refs #4091

Changeset: 39e302a462ac783b60d6ea16a5393fdebefd2bd2

[Andrei Savici]

Alex, I commented out some tests in ConvertToQ3DdE. You had some errors in OrientedLattice, in the function that calculates U from two vectors in the horizontal plane.Here is a consistency check:

1. First vector should point in the z direction

UB*u=(0,0,z)

2. Second vector is somewhere in the horizontal plane (z,x)

UB*v=(x1,0,x2).

If u and v are perpendicular, UB*v=(x,0,0)

[Alex Buts]

The algorithm has been depreciated and the implementation moved into ConvertToMDEvents

New implementation looks correct but careful comparison with existing code still needed.

[Michael Reuter]

Yes, this particular algorithm is deprecated, and I agree that the new algorithm needs careful comparison.

[Stuart Campbell]

This ticket has been transferred to github issue ​4938