Ticket #4103 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Axis Scaling after Rebinning

Reported by: Owen Arnold Owned by: Michael Reuter
Priority: major Milestone: Release 2.0
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

At present, it is possible to get into an inconsistent state with the simple user interface multislice view.

Here are the steps to follow:

  • Open the simple user interface on a MD workspace
  • Rebin it in the standard view (puts the rebinning filter into the pipeline browser)
  • Switch to multislice mode
  • Rebin with reduced extents
  • Note that the axis along the sides of the view to not update to reflect the reduced extents as a result of rebinning.

I'm not sure of the correct course of action (prevention might be best), but we should not allow users to have axis scales which provide incorrect readings. In PV, this is the only way users can tell where they are in reciprocal space given that the native PV axis labels are not doing what we want.

Change History

comment:1 Changed 9 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Michael Reuter

Refs #4103. Handling axis reorientations from rebinner.

This set of changes handles the case when the rebinner is used to change the current mapping of the x,y,z,t axes for the viewed data.

Changeset: a33f8c0d9d64b1ca5fe3ec85f5d90787471dcb9b

comment:3 Changed 9 years ago by Michael Reuter

Refs #4103. Handling bounds differences from rebinner.

This addition handles when the rebinner is just used to change the bounds of any or all of the viewed axes. The indicators now need to be updated to correct positions since the scale has changed.

Changeset: c6d64624ff53fed72ef8a33a93cc96cb28b9d1f3

comment:4 Changed 9 years ago by Michael Reuter

Refs #4103. Fix for newer Qwt version.

Changeset: 7d060410e7b6b08c825f8f386de8ec5f5b6f14f3

comment:5 Changed 9 years ago by Michael Reuter

Refs #4103. Adding bounds checking and resetting.

This set of changes handles the case from the rebinner that only the bounds for a given axis has changed. Cuts outside the bounds are deleted and ones inside are reset to make sure the graphical indicators match the new drawing of the axis scale.

Changeset: a09492417ac3849616afda57dfd8c93dd24ed7c9

comment:6 Changed 9 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

The best way to test is to use the old fe_demo_30.sqw file from the old Test/VATES directory. Load it up in either the standalone interface or via LoadSQW in MantidPlot and right-click menu. Then follow the prescription above to check. One other test scenario is to switch the axes about and see if things update correctly.

comment:7 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:8 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

This is excellent. It's doing just what I expect it to do! It even keeps the sliders at the proper location along the axis in the multislice view.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4950

Note: See TracTickets for help on using tickets.