Ticket #4105 (closed: duplicate)

Opened 9 years ago

Last modified 5 years ago

Save isaw peaks file is slow

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: owen.arnold@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

This tickets should be completed after #4104 has been completed.

Change History

comment:1 Changed 9 years ago by Owen Arnold

The following will illustrate the problem.

#where WISH00016748.raw is in the data directory as a raw file.

Load(Filename='WISH00016748.raw',OutputWorkspace='WISH00016748') ConvertToDiffractionMDWorkspace(InputWorkspace='WISH00016748',OutputWorkspace='md',SplitInto='2',SplitThreshold='100',MaxRecursionDepth='40') FindPeaksMD(InputWorkspace='md',OutputWorkspace='found_peaks') SaveIsawPeaks(InputWorkspace='found_peaks',Filename='foundpeaks.peaks')

comment:2 Changed 9 years ago by Karl Palmen

A performance test for this is needed.

comment:3 Changed 9 years ago by Karl Palmen

The WISH instrument has been found to have a structure unsuitable for IsawPeaks. SaveIsawPeaks has been modified (for ticket #4104) so that it gives an appropropriate error message about the detector modules.

The slow parformance was due to SaveIsawPeaks repeatedly searching over many instruments in the instrument tree for a detector module of type bankN and not finding it.

The issue of saving peaks for WISH will be dealt with in another ticket.

comment:4 Changed 9 years ago by Karl Palmen

  • Status changed from new to verify
  • Resolution set to duplicate

Test for this should be covered by test for ticket #4104.

comment:5 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:6 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4952

Note: See TracTickets for help on using tickets.