Ticket #4108 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SANS: Get Phi masking to work in isis sans gui

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description (last modified by Anders Markvardsen) (diff)

Currently changing the phi masking in the Analysis Details tab does not cause the table on the Masking tab to be updated.

Fix this

Attachments

MASKSANS2D_112ii_6m_commissioning_M1_M4.txt​ (1.8 KB) - added by Anders Markvardsen 9 years ago.
User file
directM1_9672_6m_08Aug11.DAT​ (8.0 KB) - added by Anders Markvardsen 9 years ago.
File required to be in the same directory as the user file

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:2 Changed 9 years ago by Anders Markvardsen

Get Phi masking to work in ISIS SANS GUI. re #4108

1) removed what appeared to be spegetti in isis_reduction_steps.py phi masking handling code 2) added entry in Masking tab for phi masking and also when phi masking is modified on analysis tab then the Masking tab is updated accordingly

Changeset: 68b54e2c2d642ea2055bd8cafb782f94e012dfcb

comment:3 Changed 9 years ago by Martyn Gigg

Refs #4108. Revert "Get Phi masking to work in ISIS SANS GUI."

This reverts commit 68b54e2c2d642ea2055bd8cafb782f94e012dfcb as it has broken most of the SANS system tests.

Changeset: 5b6cebc820ece86d44061a8430b841b87117a31a

comment:4 Changed 9 years ago by Anders Markvardsen

Get Phi masking to work in ISIS SANS GUI. re #4108

1) removed what appeared to be spegetti in isis_reduction_steps.py phi masking handling code 2) added entry in Masking tab for phi masking and also when phi masking is modified on analysis tab then the Masking tab is updated accordingly

Changeset: 68b54e2c2d642ea2055bd8cafb782f94e012dfcb

comment:5 Changed 9 years ago by Martyn Gigg

Refs #4108. Revert "Get Phi masking to work in ISIS SANS GUI."

This reverts commit 68b54e2c2d642ea2055bd8cafb782f94e012dfcb as it has broken most of the SANS system tests.

Changeset: 5b6cebc820ece86d44061a8430b841b87117a31a

comment:6 Changed 9 years ago by Anders Markvardsen

(again) phi masking to work in isis sans gui. re #4108

Changeset: 40e0ca9835863bc3395a4f6f988068775ba45b1f

comment:7 Changed 9 years ago by Anders Markvardsen

(again) phi masking to work in isis sans gui. re #4108

Changeset: 40e0ca9835863bc3395a4f6f988068775ba45b1f

comment:8 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to accepted
  • Description modified (diff)
  • Summary changed from SANS: Masking in masking tab not correct to SANS: Get Phi masking to work in isis sans gui

Changed 9 years ago by Anders Markvardsen

User file

Changed 9 years ago by Anders Markvardsen

File required to be in the same directory as the user file

comment:9 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test put the attached file in the same directory. Load the User file in the ISIS SANS GUI. Then try to modify only of the stuff on the 'Detector' area of the Analysis Details tab which should now update the 'Phi' row of the table in the Masking tab

comment:10 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This looks like it is working correctly.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4955

Note: See TracTickets for help on using tickets.