Ticket #4121 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Correctly handle VATES simple interface in right-click menu for install kits

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: critical Milestone: Release 2.0
Component: MantidPlot Keywords:
Cc: owen.arnold@… Blocked By:
Blocking: Tester: Owen Arnold

Description

Currently, the VATES simple interface is locked off from appearing in the right-click workspace menu if the MAKE_VATES flag is not used during compilation. This creates a problem for the separated install kits. Since the Mantid kit is made with MAKE_VATES off, even if the VATES install kit in place.

Change History

comment:1 Changed 9 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Michael Reuter

  • type changed from enhancement to defect

comment:3 Changed 9 years ago by Michael Reuter

Refs #4121. Removing MAKE_VATES guard for right-click menu.

I am removing the guards for the right-click workspace menu so that the VATES simple interface can be used with the separate Linux RPMs. This, however, means that MantidPlot will crash if the VATES libraries do not exist and the simple interface is called. I am working with Martyn on a solution. Also, I'm not sure what this will do to the Windows install kits.

Changeset: 1d1538d0b0f5c4521838f517aae83fc5122d9a35

comment:4 Changed 9 years ago by Michael Reuter

Refs #4121. Adding check for VATES libraries to enable/disable menu entry.

Changeset: 30fcf3bdee8431db46c608906ae8187c9d0a171a

comment:5 Changed 9 years ago by Michael Reuter

Refs #4121. Removing unneeded configuration file.

I'm removing the configuration file used to trap the VATES stuff as there is a much better way to do this.

Changeset: 3649bd3f29f356716ff4193adbe9f26176cb2031

comment:6 Changed 9 years ago by Michael Reuter

Refs #4121. Moving simple interface library to plugins dir.

I'm moving the main VATES simple interface shared library to the plugins directory in the install. This seems to bring to life the simple interface for Linux (read RHEL 6) installs. I do not know if this will effect the Windows install kits.

Changeset: 104103701807993d50f34a0d0d80ab2e94ef27fa

comment:7 Changed 9 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

This seems to work for Linux.

comment:8 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:9 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

This works quite nicely. According to the code, its looking for a particular explicitly loaded library to determine availability. So to test I Removed this library (MantidVatesSimpleGuiViewWidgets), which causes the menu option to become enabled. It's availability at start-up determines whether the SimpleGUI can be used. Verifies that the SimpleGui availability is now independent of the previous CMake flags.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4968

Note: See TracTickets for help on using tickets.