Segfault when creating an algorithm 50+ times

[Janik Zikovsky]

If you create an algorithm a number of times = to the algorithms.retained property, you get a segfault.

Will check in a test in FrameworkManagerTest that reproduces this error.

This caused segfault in my LineViewer (#4122).

[Janik Zikovsky]

Refs #4174: Test that segfaults. Fixing the ticket number.

Again, this test segfaults but is commented out. Uncomment to try. This segfault reliably for me at i==50

Changeset: 3779ede7dcde98e86f67c454e6cda1df597d4c23

[Martyn Gigg]

Janik, the problem here is actually to do with the delete on line 96 of FrameworkManagerTest. The algorithm manager keeps a deque of the last 'algorithms.retained' algorithms. When one drops off the end of the list it is deleted by the manager so I think when your loop gets to fifty there ends up being a double-delete. The first delete from your call to delete then the second one when the algorithm drops off the deque. Removing the delete should solve the problem.

[Janik Zikovsky]

Refs #4174: Martyn is correct, the delete alg is responsible.

Adding big uppercase warning to future developers NOT to delete the pointer.

Changeset: cb2f4ac3ac5acc5e519fecb110bbf91d85df48c6

[Janik Zikovsky]

Thank you Martyn for spotting that! That will fix my LineViewer problem too.

[Stuart Campbell]

This ticket has been transferred to github issue ​5021