Ticket #4188 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Different error calculation for MuonAsymmetryCalc

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: roman.tolchenov@…, robert.whitley@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Steve writes:

I worked through the errors for the asymmetry calculation last night and I think the attached result (apologies for the scruffy working!) agrees with previous code

Attached is "Steve error cal note" and screenshot of previous code.

Attachments

Steve error cal note.jpg (618.8 KB) - added by Anders Markvardsen 9 years ago.
steve error note
Screenshot of code from Muon VMS software.docx (32.0 KB) - added by Anders Markvardsen 9 years ago.
screenshot of code

Change History

Changed 9 years ago by Anders Markvardsen

steve error note

Changed 9 years ago by Anders Markvardsen

screenshot of code

comment:1 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to assigned
  • Owner changed from Anders Markvardsen to Karl Palmen

comment:2 Changed 9 years ago by Anders Markvardsen

  • Summary changed from Different error calculation for LoadMuonNexus to Different error calculation for MuonAsymmetryCalc

comment:3 Changed 9 years ago by Anders Markvardsen

Modify code in MuonAsymmetryCalc.cpp:

double quadrature = sqrt(pow(tmpWS->dataE(forward)[j], 2) + pow(tmpWS->dataE(backward)[j], 2));

double ratio = numerator && denominator ? pow(quadrature / numerator, 2) + pow(quadrature

/ denominator, 2) : 0.;

outputWS->dataE(0)[j] = sqrt( ratio )* fabs(outputWS->dataY(0)[j]);

to reflect the equation at the bottom of the attached .jpg file

comment:4 Changed 9 years ago by Anders Markvardsen

A few additional code comments. re #4188

Changeset: 7d8cdee95e16066f060430e4f796cc84f6797994

comment:5 Changed 9 years ago by Karl Palmen

Modify MuonAsymmetryCalc error calculation as instructed re #4188

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 117b6912182eabe8f5a32104ea4079edb23ae51c

comment:6 Changed 9 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:7 Changed 9 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:9 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

New error calculation implemented as in Steve's note

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5035

Note: See TracTickets for help on using tickets.