Ticket #4195 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LoadDetectorInfo takes a long time to run and consumes lots of memory

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

Jon Taylor has reported that for LET LoadDetectorInfo is taking a long time and consuming a lot of memory.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

Refs #4195. Avoid creating parametrized instruments unnecessarily.

Changeset: b9f95642e29443e87dbe35c0068138844aa29034

comment:2 Changed 9 years ago by Martyn Gigg

Refs #4195. Fix handling of array sizes for Windows.

MSVC doesn't allow non-static const ints to be array size parameters. gcc seems to be able to figure out that the const int is okay.

Changeset: 8b79a88b344d50f1b97c55c51ef320272b8be3ba

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:4 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:6 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to verify
  • Tester Russell Taylor deleted

To do the job properly, this really needs to be tested by someone who has access to an LET data file.....

comment:7 Changed 9 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:8 Changed 9 years ago by Karl Palmen

  • Status changed from verifying to closed

It took about 2 minutes to load a recent LET Nexus file (from cycle 11-4) and about 3/4 minute to load a Raw file. There were no complaints about memory (Windows 7).

comment:9 Changed 9 years ago by Karl Palmen

The Nexus file used 28,754 KB memory and the Raw file 1,669 MB.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5042

Note: See TracTickets for help on using tickets.