Ticket #4200 (closed: fixed)
Investigate Diag differnce from Libisis
| Reported by: | Nick Draper | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
Change History
comment:2 Changed 9 years ago by Martyn Gigg
It appears that MAPS has all of the detectors that are hard masked excluded from our IDF. This is throwing off comparisons and Russell would prefer if the IDF contained all of the detectors that are there. Anders is looking into this.
comment:3 Changed 9 years ago by Martyn Gigg
Refs #4200. Minor update to reference result with diag change
Changeset: 68b1a242ac0147eb93a18758405d4b24fa9460ca
comment:4 Changed 9 years ago by Martyn Gigg
Refs #4200. C++ algorithm changes to better match libisis diag.
Python script changes to follow.
Changeset: 28b7ae30f5b0be3f4247442236b01db4755cf938
comment:5 Changed 9 years ago by Martyn Gigg
Refs #4200. Diag should now match libisis.
Additional parameters were required to better match the granularity of the libisis testsx
Changeset: 1b4a05ce294d94f16b64e00879cdb6124d2b05b4
comment:6 Changed 9 years ago by Martyn Gigg
Refs #4200. Add a diag system test for MAPS
This is tested against data that libisis produced.
Changeset: 6584e9492e0bc7a331a7081ac34f7c88a8b11774
comment:7 Changed 9 years ago by Martyn Gigg
Refs #4200. Forgot to commit the updated test.
Changeset: 3676ae138a6b932c98bd12987be6ef6c435d3ed5
comment:8 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:9 Changed 9 years ago by Martyn Gigg
Refs #4200. Minor tweak for Mac system test.
Changeset: 0198b6e829b1275cfec8b4179daa6a5df725fc94
comment:10 Changed 9 years ago by Martyn Gigg
Refs #4200. Fix Homer diagnostics tab.
Changeset: 99f1afcb336d7edcfd71ffd157591b782e3c3471
comment:11 Changed 9 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:12 Changed 9 years ago by Nick Draper
Taken for verification, but I've actually asked Jon Taylor to do it as he really knows how to put it through it's paces.
comment:13 Changed 9 years ago by Nick Draper
- Status changed from verifying to closed
From Jon Taylor:
I've done quite a bit of testing with diag now. For mari it seems to work rather nicely. I've given it the worst and most varying set of data I have to date, from a period when the detectors were rather unstable and it gets the correct tubes every time.
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5047
