Ticket #4202 (closed: fixed)
SQW2 incorrect handling of non-recorded or masked data
| Reported by: | Nick Draper | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Stuart Campbell |
Description
slices through a sqw2 plot show dips around areas of non-recorded data. This should not happen as these areas should not contribute at all.
Is this just a case of masking these bins?
Change History
comment:2 Changed 9 years ago by Martyn Gigg
- type changed from enhancement to defect
- Milestone changed from Iteration 33 to Iteration 32
Needs to be done for 2.0 release
comment:3 Changed 9 years ago by Martyn Gigg
Refs #4202. Better handling of theta widths in SofQW2.
Needs verification and error handling + parallelization.
Changeset: a7c7232531a7265b48568c670b5ba5b193f07d30
comment:4 Changed 9 years ago by Martyn Gigg
Refs #4202. Fix a factor of 2 error in bin size calc.
Changeset: 93b74bfd0e90443d3a0f66c3d9cf1dbc1748ba06
comment:5 Changed 9 years ago by Martyn Gigg
Refs #4202. Better handling of theta widths in SofQW2.
Needs verification and error handling + parallelization.
Changeset: a7c7232531a7265b48568c670b5ba5b193f07d30
comment:6 Changed 9 years ago by Martyn Gigg
Refs #4202. Fix a factor of 2 error in bin size calc.
Changeset: 93b74bfd0e90443d3a0f66c3d9cf1dbc1748ba06
comment:7 Changed 9 years ago by Stuart Campbell
Just thought I would let you know that this goes back to giving me all zeros.
comment:8 Changed 9 years ago by Stuart Campbell
It's just BASIS that gives zeros - I presume it is because some of our detectors don't have an Efixed associated with them. I think it would be ok to just mask these out.
comment:9 Changed 9 years ago by Martyn Gigg
Refs #4202. Fix normalisation of SofQW2
Also fix SofQW for new BASIS definition where some detectors have no efixed.
Changeset: 2b1a6cbe4c2e4d300e9d7d894b46252a351e23c0
comment:10 Changed 9 years ago by Martyn Gigg
Refs #4202. Fix tests.
Changeset: 637e52d03ac070ce0261bb9b54e6e70110326de1
comment:11 Changed 9 years ago by Martyn Gigg
Refs #4202. Clear some race conditions.
Changeset: 35053ffc3d2bb1114a4825820e98d844642d1a06
comment:12 Changed 9 years ago by Martyn Gigg
Refs #4202. Adjustment to cope with detector gaps.
Changeset: df140e439134d91fff6e87eccf1a829039256f58
comment:13 Changed 9 years ago by Martyn Gigg
Refs #4202 Refs #4683. Merge much of code for Rebin2D & SofQW2
This solves the edge effect issue for Rebin2D and SofQW2 should now be correctly normalised.
Changeset: 2f0168eab509c268f14619879083701331bfb57d
comment:15 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:16 Changed 9 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:17 Changed 9 years ago by Stuart Campbell
- Status changed from verifying to closed
Using MAR11001.raw, loaded, converted to dE, rebinned then ran SofQW2. Then ran transpose, and just plotted various spectra.
The 1d line plot shows the data going to zero in the gaps between detectors banks.
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5049
Moved to iteration 33 at iteration 32 code freeze