Ticket #4205 (closed: fixed)
Modify flow in IntegratePeakTimeSlices to get better results
| Reported by: | Ruth Mikkelson | Owned by: | Ruth Mikkelson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Vickie Lynch |
Description
Two alterations were made.
- A first pass, without optimization, is used to find the time slice with the largest counts.
- The area of the rectangular region is essentially the same on each time slice. These areas were calculated from the data. They seemed to increase with time slices away from the center( possible diffuse scattering).
Change History
comment:2 Changed 9 years ago by Ruth Mikkelson
Refs #4205. Commented out tests that failed
Changeset: 7930b81177046fcdd7525ffd77b9c5e04c8f5bd0
comment:3 Changed 9 years ago by Ruth Mikkelson
Commented out tests that did not work Refs #4205
Changeset: c19ce569694eaa0ff07f99c21e01d75e4633e15d
comment:4 Changed 9 years ago by Ruth Mikkelson
Reinstated CMakeLists.txt Refs #4205
Changeset: 5e6e61e2c733c9c86f7ae512610a6acc2bcf0f68
comment:5 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:7 Changed 8 years ago by Ruth Mikkelson
- Status changed from accepted to verify
- Resolution set to fixed
comment:8 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:9 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to reopened
- Resolution fixed deleted
Please remove initCommon prints from BivariateNormal.cpp
Also I got a few -nan in the SigInt column integrating TOPAZ_3131, so please add a check for the variance nonnegative before taking sqrt. After these two minor changes, I will pass ticket.
comment:10 Changed 8 years ago by Ruth Mikkelson
Refs #4205. Fixed NaN problem. Could Not find other problem
Changeset: ab3b5db2f8e5a7f92bc1f6f891ba62950881f822
comment:11 Changed 8 years ago by Vickie Lynch
Janik removed the initCommon prints. See REfs #4472 removed debugging output. If you close, I will pass the ticket. Vickie
comment:13 Changed 8 years ago by Ruth Mikkelson
- Status changed from accepted to verify
- Resolution set to fixed
comment:15 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to closed
Compares well with IntegratePeaksMD. No -nans.
comment:16 Changed 8 years ago by Ruth Mikkelson
Refs #4205. Fixed NaN problem. Could Not find other problem
Changeset: ab3b5db2f8e5a7f92bc1f6f891ba62950881f822
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5052
Updated test programs. Used larger errors. Refs #4205