Ticket #4253 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Crash when showing Instrument Window after LoadEmptyInstrument/makeEventWorkspace

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 2.0
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Jean Bilheux

Description

The reason is the same as in the crash fixed in [0417a473]. It's trusting readX not to return and empty vector.

Stack trace: 

InstrumentActor::InstrumentActor() at InstrumentActor.cpp:47 0x9de6e5	
InstrumentWindow::init() at InstrumentWindow.cpp:202 0x9ea389	
MantidUI::getInstrumentView() at MantidUI.cpp:1,794 0x9aa833	
MantidUI::showMantidInstrument() at MantidUI.cpp:1,830 0x9aac34	
MantidUI::showMantidInstrumentSelected() at MantidUI.cpp:1,852 0x9aad8a

Change History

comment:1 Changed 9 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Russell Taylor

Give an EventWorkspace 1 X bin on initialisation. Re #4253.

With values of 0 & 0 + a tiny bit. Normally the data loaders set the single bin values to the min & max for all the events, but an empty workpace doesn't get this and there are places that assume these vectors are not empty.

Changeset: 0bb5824504e468bdf97b66cf50c85434289ad7dd

comment:3 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

To test:

  • Run LoadEmptyInstrument, checking the box to create an EventWorkspace
  • Show the instrument. Note the absence of a crash!
  • Display the matrix, which will have 1 bin in X with values of 0 and something like 2x10-308

comment:4 Changed 9 years ago by Jean Bilheux

  • Status changed from verify to verifying
  • Tester set to Jean Bilheux

comment:5 Changed 9 years ago by Jean Bilheux

  • Status changed from verifying to closed

works

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5100

Note: See TracTickets for help on using tickets.