Ticket #4279 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SetGoniometer does not immediately sets values

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: trivial Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

If you apply SetGoniometer algorithm, and you save the workspace as a NeXus file, the angle is saved as 0. It will probably work OK since it is still linked to the log value. It should be easier to see the value if one just browses the file.

Change History

comment:1 Changed 9 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Andrei Savici

Also, for the Run object, when calculating the goniometer rotation matrix, it should use the average log values for angles, instead of the first value

comment:3 Changed 9 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

SetGoniometer updates angle values with the mean. Refs #4279

Changeset: e88a750efde96ef014a021828a293b236f850968

comment:4 Changed 9 years ago by Andrei Savici

Here is how you can test it:

  1. Load CNCS_7860_event.nxs
  2. SetGoniometer frequency,0,1,0,1 - frequency has the first value 0, but all other around 59.97
  3. SaveNexus
  4. With hdfview navigate to logs->goniometer->angle. The value should be 59.97

comment:5 Changed 9 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:6 Changed 9 years ago by Peter Parker

  • Status changed from verifying to closed

Followed prescribed test, with output of 59.970263111123806.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5126

Note: See TracTickets for help on using tickets.