Ticket #4282 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Investigate 'Floating windows' for graphs, matrices etc

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By: #4431
Blocking: Tester: Andrei Savici

Description

We need to know, what we can do so we can decide what we should do

Change History

comment:1 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Russell Taylor

Is it going to be a user option whether the windows 'float away' or stay as they are now? I think it should be, if possible.

comment:3 Changed 9 years ago by Roman Tolchenov

Re #4282. Changed MdiSubWindow to be switchable from mdi to floating

Changeset: 19f6d94ce48ef23b0052bc10b8161d25885826bb

comment:4 Changed 9 years ago by Roman Tolchenov

Re #4282. Some small changes

Changeset: 4241b69d2e63b59bd2ef9c82ffa53ab13609c265

comment:5 Changed 9 years ago by Roman Tolchenov

Re #4282. Saving working progress.

Changeset: 19c389942954038d431310463f90fabe6e272802

comment:6 Changed 9 years ago by Roman Tolchenov

Re #4282. Working progress

Changeset: baff030daa5cf4d5ce4a2d3502a15e6d96ca1045

comment:7 Changed 9 years ago by Roman Tolchenov

Re #4282. Removed wrapper widget from FloatingWindow

Changeset: 4cdcf1f172a80e9397989763745d93f693573aea

comment:8 Changed 9 years ago by Roman Tolchenov

Re #4282. Almost working on Windows.

Changeset: 3d2abdc6e0ad39751d076084d449006e1d59cb44

comment:9 Changed 9 years ago by Roman Tolchenov

Re #4282. Trying to make menu bar work on Ubuntu 11

Changeset: cc4d0ee19f453245a89184fe5165c63ce061f1f8

comment:10 Changed 9 years ago by Roman Tolchenov

Re #4282. More support for shared menu bar.

Changeset: 863eb391024b32eb3e6055a3b0076a3394917b21

comment:11 Changed 9 years ago by Roman Tolchenov

Re #4282. Added preferences for floating windows

Changeset: 69796344dfe109b9690f95cbdf4894eac636651e

comment:12 Changed 9 years ago by Roman Tolchenov

Re #4282. More preferences. Added switch floating - docked

Changeset: a1c58bf6cf0500e9b91ae20478e0379efca1c07f

comment:13 Changed 9 years ago by Roman Tolchenov

Re #4282. Improving floating windows performance

Changeset: cf90b6e4f85252aa814fb762b975e387578643ba

comment:14 Changed 9 years ago by Roman Tolchenov

Re #4282. Small ajustment to window activation

Changeset: 3569da586ddf0489a9b5626a7d5c0a83bc7d4e6c

comment:15 Changed 9 years ago by Roman Tolchenov

Re #4282. Added a comment to the config page

Changeset: 1b76526d2b850da77cf7b9c2d5bb3a4522c10562

comment:16 Changed 9 years ago by Roman Tolchenov

Re #4282. Corrected a mistake in ifdef

Changeset: 6a4893c3b0a8193edec4eafb04f061a3a5d82ada

comment:17 Changed 9 years ago by Roman Tolchenov

Re #4282. Added a comment to the config page

Changeset: 1b76526d2b850da77cf7b9c2d5bb3a4522c10562

comment:18 Changed 9 years ago by Roman Tolchenov

Re #4282. Corrected a mistake in ifdef

Changeset: 6a4893c3b0a8193edec4eafb04f061a3a5d82ada

comment:19 Changed 9 years ago by Roman Tolchenov

Re #4282. Merging floatable_windows into master

Changeset: 4c24958ae57faf80f3831fb9cedac854b9268484

comment:20 Changed 9 years ago by Roman Tolchenov

Re #4282. Fixing the builds

Changeset: 5839a17a014b615022587735b8b7b7c617554459

comment:21 Changed 9 years ago by Russell Taylor

A couple of comments applicable to RHEL6: If I create a floating window and then change workspace, the window follows me! Also, closing the window does not appear to delete the object properly (it's still accessible via python).

comment:22 Changed 9 years ago by Russell Taylor

Also, it looks like the ability to plot a spectrum by dragging a workspace name onto an existing graph has gone.

P.S. Teething troubles aside I think this is really nice!

comment:23 Changed 9 years ago by Roman Tolchenov

Re #4282. Adding CustomInterfaces to the framework

Changeset: 6b0ef8a19f95a1dd9dba0bac056a04486569ca4f

comment:24 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:25 Changed 9 years ago by Roman Tolchenov

  • Milestone changed from Iteration 33 to Iteration 32

comment:26 Changed 9 years ago by Roman Tolchenov

Re #4282. Custom interfaces should now be properly connected

Changeset: ffe93347ee51f9d0df1aaf3cbe91cf2daea01bf4

comment:27 Changed 9 years ago by Roman Tolchenov

Re #4282. MdiSubWindow passes closeEvent to its inner widget

Changeset: fbd451fc28f0f4570d1a47dd266758b4167d2ec1

comment:28 Changed 9 years ago by Roman Tolchenov

Re #4282. Fix for the Table crash

Changeset: 67abb2b64e5a928bd94b552bedc0334e84c9611e

comment:29 Changed 9 years ago by Janik Zikovsky

Refs #4282: just indentation/code reuse fix

Changeset: 4d8f90a0210f5ae2f912cfacc09df06fa9340676

comment:30 Changed 9 years ago by Russell Taylor

  • Blocked By 4431 added

comment:31 Changed 9 years ago by Janik Zikovsky

Refs #1037: Unit test for mantid plot python proxies

Exposed the close() method to python so that the windows close properly from python. Refs #4282: make sure the FloatingWindow is deleted when closed. Testing several proxy methods. Russell: Layer.legend() and Layer.grid() do not work for me!

Changeset: 2c795e49bff68c98d2f0df3b26d5f6e5f44bcbb2

comment:32 Changed 9 years ago by Roman Tolchenov

Re #4282. Fix the MantidMatrix dependency issue

Changeset: 960dd98af7380f5390eecb7d1e6b65e087496ceb

comment:33 Changed 9 years ago by Roman Tolchenov

Re #4282. More checks on validity of active window pointer

Changeset: 808a62d64ace52c0402a3113b134f00c9794f40b

comment:34 Changed 9 years ago by Roman Tolchenov

Re #4282. Correcting a mistake

Changeset: 58c49eecdd9ce6e9ca9eb323eb9d594c2bbb873b

comment:35 Changed 9 years ago by Roman Tolchenov

Re #4282. The menubar should be back on again

Changeset: 15e4cf2332815cbfb03a9725696b6cafc05e0b3c

comment:36 Changed 9 years ago by Roman Tolchenov

Re #4282. A correction to folders behaviour

Changeset: 27406e7af11358d3d3207fa9abc9bc2329075a91

comment:37 Changed 9 years ago by Roman Tolchenov

Re #4282. Made window positioning a bit smarter

Changeset: e32d626390786b6350cef635079c0c41e9d1c171

comment:38 Changed 9 years ago by Roman Tolchenov

Re #4282. Set parent of many dialogs to graphs instead of AppWind

Changeset: 0119b1fb2833de2b40ae3df181b7381e0bf1ef3e

comment:39 Changed 9 years ago by Roman Tolchenov

Re #4282. Fixed the response to Cancel (on close) button

Changeset: 405e95c77eb5f0bb6d20b287354a6104ff4d0dd0

comment:40 Changed 9 years ago by Roman Tolchenov

Re #4282. Fixed dialogs failing to show on double-click

Changeset: 3ce48441142c2a0179afdc3a3049f8572d28b823

comment:41 Changed 9 years ago by Russell Taylor

Expose MdiSubWindow hide() & show() to python. Re #4282.

This makes calling show & hide work from python instead of leaving the 'wrapper' window there. HOWEVER, I'm not sure we should be overriding these methods - they are not virtual methods (neither is close()). setVisible() - which these two call - IS virtual, but when I tried to implement that instead it completely messed up the appearance of the instrument window and the custom interfaces for some reason.

Changeset: 331f51e2834b7c3983cb7daef496976b437da773

Last edited 9 years ago by Russell Taylor (previous) (diff)

comment:42 Changed 9 years ago by Russell Taylor

Update on how floating windows look from where I'm sitting:

  • On linux, they still wind up at the back as soon as another window is made active.
  • On the Mac they stay at the front. However, on that platform minimising a floating window tends to minimise the main application window as well.

comment:43 Changed 9 years ago by Roman Tolchenov

Re #4282. Fixed window minimizing on Mac

Changeset: e21f3e99bb395e4d2ffe1d8b339767ddcdced59a

comment:44 Changed 9 years ago by Roman Tolchenov

Re #4282. A correction for Windows

Changeset: f6a65afff6e709569a0b2925c322e6ef6f3dbfd3

comment:45 Changed 9 years ago by Russell Taylor

Minimizing behaves on the Mac now, but what happens there now is that floating windows disappear to the back like on Linux - and they're actually harder to get to because there's no taskbar for them to appear in.

comment:46 Changed 9 years ago by Roman Tolchenov

I think they do appear in the taskbar (or whatever it is called on Mac). With my limited knowledge of mac I had to make a choice: either windows stay on top or they can minimize properly.

comment:47 Changed 9 years ago by Russell Taylor

The only appear there when minimized (this is on Snow Leopard - don't know if Lion looks any different). When they're at the back and not minimized you're looking at making sure MantidPlot isn't maximized and moving things around to find them.

comment:48 Changed 9 years ago by Roman Tolchenov

Re #4282. Change some dialog parents to a floating window

Changeset: fc55e640bb6ce793e93f67b85c1a7fdb776486e6

comment:49 Changed 9 years ago by Roman Tolchenov

Re #4282. Fixed dialogs failing to show on double-click

Changeset: 3ce48441142c2a0179afdc3a3049f8572d28b823

comment:50 Changed 9 years ago by Russell Taylor

Expose MdiSubWindow hide() & show() to python. Re #4282.

This makes calling show & hide work from python instead of leaving the 'wrapper' window there. HOWEVER, I'm not sure we should be overriding these methods - they are not virtual methods (neither is close()). setVisible() - which these two call

  • IS virtual, but when I tried to implement that instead it completely

messed up the appearance of the instrument window and the custom interfaces for some reason.

Changeset: 331f51e2834b7c3983cb7daef496976b437da773

comment:51 Changed 9 years ago by Roman Tolchenov

Re #4282. Fixed window minimizing on Mac

Changeset: e21f3e99bb395e4d2ffe1d8b339767ddcdced59a

comment:52 Changed 9 years ago by Roman Tolchenov

Re #4282. A correction for Windows

Changeset: f6a65afff6e709569a0b2925c322e6ef6f3dbfd3

comment:53 Changed 9 years ago by Roman Tolchenov

Re #4282. Change some dialog parents to a floating window

Changeset: fc55e640bb6ce793e93f67b85c1a7fdb776486e6

comment:54 Changed 9 years ago by Roman Tolchenov

Re #4282. Improved window handling by project explorer

Changeset: c70caeea6ee4833b4046e6039e248417c7f6cc95

comment:55 Changed 9 years ago by Roman Tolchenov

Revert "Re #4282. Improved window handling by project explorer"

This reverts commit c70caeea6ee4833b4046e6039e248417c7f6cc95.

Changeset: 301f0b8dfb69e069350003100a6165a3ab084787

comment:56 Changed 9 years ago by Roman Tolchenov

Re #4282. Improved window handling by project explorer

Changeset: c70caeea6ee4833b4046e6039e248417c7f6cc95

comment:57 Changed 9 years ago by Roman Tolchenov

Revert "Re #4282. Improved window handling by project explorer"

This reverts commit c70caeea6ee4833b4046e6039e248417c7f6cc95.

Changeset: 301f0b8dfb69e069350003100a6165a3ab084787

comment:58 Changed 9 years ago by Roman Tolchenov

Re #4282. Restoring the reverted changes + fixing the GUI test.

Changeset: 7a8495efff4f1d05538c66ce557f70c5dc703750

comment:59 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:60 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:61 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to closed

I was able to change from floating to docking and back, also to set the preference of floating or docked for new windows. Seems to be working fine

comment:62 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5129

Note: See TracTickets for help on using tickets.