Ticket #4288 (closed: fixed)
Improve Nearest Neighbours
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | VATES | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Janik Zikovsky |
Description
Change the nearest neighbour code so that we can extract the distance V3D distance = neighbour - realPos; rather than just the absoute distance. This will affect a lot of code, so It's important that nothing breaks as a result of this change.
This ticket is necessary in order to support #4203 and fix an minor issue in parabolic smoothing. Currently parabolic smoothing will only work for rectangular detectors, but it should work for instruments like WISH at the end of this ticket.
Attachments
Change History
comment:2 Changed 9 years ago by Owen Arnold
refs #4288 #4203. Changes to NNs made.
Changes made and Unit tests corrected and re-run. Seems to have worked okay.
Changeset: 8b0d6a1a8413fd153898f3dbeabfddaa29b91e97
comment:3 Changed 9 years ago by Owen Arnold
Update Wiki documentation for this important change http://www.mantidproject.org/Nearest_Neighbours
comment:4 Changed 9 years ago by Owen Arnold
refs #4288 #4203. Gaussian and Parabolic weighting updated.
Parabolic weighting can now work for non-rectangular detectors. Updated gaussian smoothing to be consistent with LibISIS. Also updated documentation for SmoothNeighbours.
Changeset: 752651aca9329755dd03b4c68b747669e5105caa
comment:5 Changed 9 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester:
Parabolic smoothing was not possible until the nearest neighbours had been updated to return distances in vector form, so you can test as follows:
-Change log level to information -Run this script
file_to_load = "C:/Users/spu92482/Documents/mantid/mantid/Test/AutoTestData/CNCS_7860_event.nxs"
LoadEventNexus(Filename=file_to_load,OutputWorkspace="cncs")
SmoothNeighbours(InputWorkspace="cncs", OutputWorkspace="parabolic_smoothed", RadiusUnits="NumberOfPixels",Radius=100,NumberOfNeighbours=48,WeightedSum="Parabolic")
-Parabolic Smoothing should have been written to logs -Open the original workspace and the smoothed workspace in the instrument view and compare the images. -Check unit tests
Changed 9 years ago by Russell Taylor
- Attachment GeometryTest.NearestNeighboursTestPerformance.testUsingDefault.runtime.v.revision.png added
Performance test change
Changed 9 years ago by Russell Taylor
- Attachment GeometryTest.NearestNeighboursTestPerformance.testUsingRadius.runtime.v.revision.png added
comment:6 Changed 9 years ago by Russell Taylor
The top commit had a noticeable effect on the NN performance tests. Maybe it's not a surprise but I thought I'd better point it out just in case.
comment:7 Changed 9 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
