Ticket #4297 (closed: fixed)
Code improvements according to code review
| Reported by: | Anders Markvardsen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | Infrastructure | Keywords: | |
| Cc: | martyn.gigg@… | Blocked By: | |
| Blocking: | Tester: | Anders Markvardsen |
Description
1) Format code in PeakWorkspace and a few other places.
2) In PeaksWorkspace pre-allocate vectors in saveNexus
3) Optionally refactor something like
file->writeData("column_1", detectorID); file->openData("column_1"); file->putAttr("name", "Dectector ID"); file->putAttr("interpret_as","An integer"); file->putAttr("units","Not known"); file->closeData();
into a private method.
4) Create a double const string aDouble="A double" and use saveNexus method
5) Remove scope in DataAndTime and replace '\n' with std::endl()
Change History
comment:2 Changed 9 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
comment:3 Changed 9 years ago by Karl Palmen
- Component changed from Mantid to Infrastructure
Decided not to do optional (3) because to do it well, would require advance features of C++, I'm not yet familar with.
comment:4 Changed 9 years ago by Stuart Campbell
Fix Compiler Warning. refs #3868 & #4297
Changeset: e71079a05768d5d48178a340a6c3a90148d36c94
comment:5 Changed 9 years ago by Karl Palmen
Made changes (1), (2), (4) and (5) in re #4297
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 7473c645b037c09624279e323ff5830760999d92
comment:6 Changed 9 years ago by Stuart Campbell
Fix Compiler Warning. refs #3868 & #4297
Changeset: e71079a05768d5d48178a340a6c3a90148d36c94
comment:7 Changed 9 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
