Ticket #4309 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Allow use of space/tab in SaveAscii

Reported by: Peter Parker Owned by: Peter Parker
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Robert Whitley

Description

Currently, whitespace is not parsed and the default of a comma is used instead. Also, tabs cannot be inputted since it simply moves focus to the next field.

Change History

comment:1 Changed 9 years ago by Peter Parker

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Peter Parker

Refs #4309 - Only SaveAscii modified to allow spaces and tabs.

Drop down menu added (via a ListValidator property) to allow user to pick from same options found in LoadAscii. If they pick a choice of "User Defined", then they can also input a custom separator.

Changeset: 941d66c61fedb5a3d6dbdda7a8cbc64fcf082243

comment:3 Changed 9 years ago by Peter Parker

Refs #4309 - Only SaveAscii modified to allow spaces and tabs.

Drop down menu added (via a ListValidator property) to allow user to pick from same options found in LoadAscii. If they pick a choice of "User Defined", then they can also input a custom separator.

Changeset: 941d66c61fedb5a3d6dbdda7a8cbc64fcf082243

comment:4 Changed 9 years ago by Russell Taylor

The above commit was reverted in [c35036af] (trac hook failed).

Revert "Refs #4309 - Only SaveAscii modified to allow spaces and tabs."

This reverts commit [941d66c6].

Mathieu says "Sorry for the revert but that commit broke the SANS reduction. Let's discuss what needs to be done."

Last edited 9 years ago by Russell Taylor (previous) (diff)

comment:5 Changed 9 years ago by Peter Parker

"Un-reverts" a revert made to SaveAscii.

This reverts commit c35036affa527e2ab0d41a4a3a38ab220873ef98, as well as changing the two places where SaveAscii is called with a separator specified. This should ensure ORNL SANS reduction still works. Refs #4309.

Changeset: eaece9d766930d0c227a5c62ad074563cad6a279

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:7 Changed 9 years ago by Russell Taylor

  • Milestone changed from Iteration 33 to Iteration 32

Is this complete? If so it should just be marked fixed. If not, a follow up ticket should be written and this one closed.

The reason is that this changes the algorithm signature in a way that will break any scripts that use it (that aren't in our repository). In general this is something we try to avoid, so at minimum this needs to be mentioned in the release notes - that's why I've moved it back to Iteration 32.

comment:8 Changed 9 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Summary changed from Allow use of space/tab in SaveAscii/CSV to Allow use of space/tab in SaveAscii

This is complete - my mistake for not marking it as such.

The decision was made to change the algorithm signature as it was the most sensible way to implement the previously missing space/tab functionality via the UI (though "/t" was working elsewhere). SaveAscii now works in a more synergistic and uniform manner with its sister algorithm, LoadAscii.

Updated Wiki: http://www.mantidproject.org/SaveAscii.

comment:9 Changed 9 years ago by Robert Whitley

  • Status changed from verify to verifying
  • Tester set to Robert Whitley

comment:10 Changed 9 years ago by Robert Whitley

  • Status changed from verifying to closed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5156

Note: See TracTickets for help on using tickets.