Ticket #4321 (closed: fixed)
SANS: extra check of PixelAdj in Q1D & Qxy
| Reported by: | Anders Markvardsen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Anders Markvardsen |
Description
check in Q1D and Qxy that if the input parameter PixelAdj contains numbers less than or equal to zero for none masked pixels a warning/error is thrown to match SK comment: we used 0 for the efficiency of the monitor spectra in the flat cell and -1 for unused/irrelevant spectra.
Change History
comment:1 Changed 9 years ago by Anders Markvardsen
- Status changed from new to assigned
- Owner changed from Anders Markvardsen to Karl Palmen
- Priority changed from critical to major
comment:2 Changed 9 years ago by Michael Reuter
Refs #4321. Updates to tests.
Changeset: 58fba8c3cc7fff1936c1301bf3d1369ef98dc752
comment:4 Changed 9 years ago by Michael Reuter
Refs #4321. Updates to tests.
Changeset: 58fba8c3cc7fff1936c1301bf3d1369ef98dc752
comment:6 Changed 9 years ago by Karl Palmen
Correct a comment re #4321
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d64301bb410351272934842bd616389c18a7cc4f
comment:7 Changed 9 years ago by Karl Palmen
Check bounding box first, so that error can be thrown re #4321
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2787a8c9c2c6c67993e769d01463c80f8c9c16b4
comment:8 Changed 9 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
comment:9 Changed 9 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:10 Changed 9 years ago by Anders Markvardsen
- Status changed from verifying to closed
Implemented and unit tested
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5168
Also add unit test to Q1D2Test. Add method createInputWorkspacesMask which load the WS created by createInputWorkspaces() and mask some of its pixels. Then create new test where a) create pixelAdj WS as a chop of WS from createInputWorkspaces(). Then run Q1D where a) chopped WS have zeros for masked pixels - should pass b) where chopped WS have zeros for pixels which are not masked - should fail c) where chopeed WS have all positive values - should pass.