Ticket #4338 (closed: fixed)
MUON: Add CalMuonDeadTime to MuonAnalysis
Reported by: | Anders Markvardsen | Owned by: | Robert Whitley |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.1 |
Component: | Mantid | Keywords: | |
Cc: | robert.whitley@… | Blocked By: | |
Blocking: | Tester: | Anders Markvardsen |
Description
This tickets follows #4337
In the top part of MuonAnalysis front tab and row so you have something like:
Time Zero (ys):
First Good Data (ys):
Deadtime correction: text-line
where text-line is an usual box for a user to select a Muon Nexus file from.
If this box is empty all works as per usual.
Otherwise when such a file is selected then
- run it through CalMuonDeadTime and catch output DeadTimeTable property.
- When any subsequent run are selected. In void MuonAnalysis::inputFileChanged(const QString& filename) execute early on a method which first do some basic checks to see if DeadTimeTable matches the selected run data file and then run AppleDeadTime algorithm)
Change History
comment:2 Changed 9 years ago by Anders Markvardsen
- Owner changed from Anders Markvardsen to Robert Whitley
- Status changed from new to assigned
- Priority changed from major to critical
Hi Rob,
Note implement the 2nd description of this ticket not the 1st.
Also for this second description, initially start with implement only 'None' and 'chose table' and have the combobox to default to 'None' to begin with.
comment:3 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:5 Changed 9 years ago by Robert Whitley
Refs #4338. Added UI options and set up signals, slots and validation
Changeset: 2ae2a4afc58adf5f37eb427651c04c60a5490d06
comment:6 Changed 9 years ago by Robert Whitley
I need to change the Load Muon Nexus algorithms to output dead time tables. This will be applied to the muon data if the option to do so is selected.
comment:7 Changed 9 years ago by Robert Whitley
Refs #4338. Remove signal and slot connection while it doesn't exist.
Changeset: 8bdaef6956092ece04422ca913bbfeeaee69dd25
comment:8 Changed 9 years ago by Robert Whitley
Refs #4338. Added dead time property to LoadMuonNexus.
Used C++ for algorithms instead of python in hope to be quicker. Modified unit test of LoadMuonNexus to take into account new property
Changeset: 5c56aa872aa746245e4c21ea1e80bb52a592cac6
comment:9 Changed 9 years ago by Robert Whitley
Refs #4338. static_cast the floats into doubles for dead times.
Changeset: d9d2e24383ec869b5f9a2d1f1dc9dd201b898a9b
comment:10 Changed 9 years ago by Robert Whitley
Refs #4338. Apply the data's dead time values for MUSR and EMU.
Changeset: 58e19f7baa2a2748dfd7efc8467b7e928bbcb11a
comment:11 Changed 9 years ago by Robert Whitley
Refs #4338.Fix build not knowing how to assign to declared std:string
Changeset: fa098b3d9b62f616a5771bce36a20b47fd5fb792
comment:12 Changed 9 years ago by Robert Whitley
Refs #4338. Added UI options and set up signals, slots and validation
Changeset: 2ae2a4afc58adf5f37eb427651c04c60a5490d06
comment:13 Changed 9 years ago by Robert Whitley
Refs #4338. Remove signal and slot connection while it doesn't exist.
Changeset: 8bdaef6956092ece04422ca913bbfeeaee69dd25
comment:14 Changed 9 years ago by Robert Whitley
Refs #4338. Added dead time property to LoadMuonNexus.
Used C++ for algorithms instead of python in hope to be quicker. Modified unit test of LoadMuonNexus to take into account new property
Changeset: 5c56aa872aa746245e4c21ea1e80bb52a592cac6
comment:15 Changed 9 years ago by Robert Whitley
Refs #4338. static_cast the floats into doubles for dead times.
Changeset: d9d2e24383ec869b5f9a2d1f1dc9dd201b898a9b
comment:16 Changed 9 years ago by Robert Whitley
Refs #4338. Apply the data's dead time values for MUSR and EMU.
Changeset: 58e19f7baa2a2748dfd7efc8467b7e928bbcb11a
comment:17 Changed 9 years ago by Robert Whitley
Refs #4338.Fix build not knowing how to assign to declared std:string
Changeset: fa098b3d9b62f616a5771bce36a20b47fd5fb792
comment:18 Changed 9 years ago by Robert Whitley
Refs #4338. Make a more robust way of apply dead times from the data.
Make a start on applying dead times from a user specified file.
Changeset: 53def175c99b0987753fc1e381d43868ac537f93
comment:19 Changed 9 years ago by Robert Whitley
Refs #4338. Remove std::cout from LoadMuonNexus (left in by mistake).
Changeset: fbe6db556fbb85aa68f336dc7b6f66a5c9be8188
comment:20 Changed 9 years ago by Robert Whitley
Refs #4338. Add ability to apply dead times from a specified file.
Changeset: cdfd6930ee56a14566cbb17116b6bff05f3383e3
comment:21 Changed 9 years ago by Robert Whitley
Refs #4338. Fix Compiler Warnings.
Changeset: 24e9deec99fb770aa18b5506e0d29879be8a9a71
comment:22 Changed 9 years ago by Robert Whitley
Refs #4338. Fix another compiler warning.
Changeset: 04f78b744d5d9a57b7e84cef93d2ed3374a3b262
comment:23 Changed 9 years ago by Robert Whitley
Refs #4338.Allow dead time type to change and 'work' on the same data
Changeset: 4004c12b1ca9530c0d13d5400006ca274dbcdbd3
comment:24 Changed 9 years ago by Robert Whitley
- Status changed from accepted to verify
- Resolution set to fixed
comment:25 Changed 9 years ago by Robert Whitley
- Status changed from verify to reopened
- Resolution fixed deleted
comment:26 Changed 9 years ago by Robert Whitley
- Status changed from reopened to accepted
The new options don't look right on the Mac. Changes will be needed so that the writing isn't squashed together.
comment:27 Changed 9 years ago by Robert Whitley
Refs #4338. Change the layout so that it works on Mac.
Changeset: 8b79809bd9f13adfd5d8208ad6fab1411f23e6c8
comment:28 Changed 9 years ago by Robert Whitley
Refs #4338. More small changes to layout.
Changeset: 4badfacdd7276a1d9843c0ac4705c82236839e64
comment:29 Changed 9 years ago by Robert Whitley
- Status changed from accepted to verify
- Resolution set to fixed
comment:30 Changed 8 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:31 Changed 8 years ago by Anders Markvardsen
- Status changed from verifying to closed
Tested this by first cal a deadtime table using CalMuonDeadTime and then apply this time using the MuonAnalysis interface
comment:32 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5185
NEW executive Muon description for this ticket:
In the top part of MuonAnalysis front tab and row so you have something like:
Time Zero (ys):
First Good Data (ys):
Deadtime correction: combo-box
where combo-box have the fields: 'From data file', 'None' and 'Chose table'
where 'From data file' means that some field in the Nexus file is read which stores a deadtime table. 'None' means works as normal. 'Chose table' will create a text-area next to it for specifying the name of a TableWorkspace.
Otherwise as in description above except no need to call CalMuonDeadTime.