Ticket #4351 (closed: fixed)
GroupDetectors should average by the number of spectra not detectors in the new group
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Peterson |
Description
GroupDetectors currently averages by the number of detectors in the newly created group. On instruments with hardware grouping this can lead to inconsistent averaging. This was noticed on MERLIN where their short tubes have an 8:1 mapping at the hardware level but the long tubes have a 4:1. When running GroupDetectors2 in averaging mode with a 1:1 map file you get an odd area of lower intensity with the short tubes after running GroupDetectors. See picture
Attachments
Change History
Changed 9 years ago by Martyn Gigg
- Attachment Screenshot-1.png added
comment:1 Changed 9 years ago by Martyn Gigg
Refs #4351. GroupDetectors2 averages by number of spectra not dets.
For instruments that group at the hardware level this is important as a 1:1 map file can lead to averaging by greater than 1 detector.
Changeset: ffd6937acf3f8c1fe3b1365d37832ff90c0402c5
comment:2 Changed 9 years ago by Martyn Gigg
Refs #4351. GroupDetectors2 averages by number of spectra not dets.
For instruments that group at the hardware level this is important as a 1:1 map file can lead to averaging by greater than 1 detector.
Changeset: ffd6937acf3f8c1fe3b1365d37832ff90c0402c5
comment:4 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:5 Changed 9 years ago by Nick Draper
- Status changed from verify to reopened
- Resolution fixed deleted
problem reported to have reappeared with merlin short tubes.
Discovered in version 2906, although may have been present for some time.
comment:7 Changed 9 years ago by Martyn Gigg
GroupDetectors is actually okay. The problem turned out to be the DetectorEfficiencyCor algorithm so I think another ticket is in order: #4499
comment:8 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:9 Changed 9 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:10 Changed 9 years ago by Peter Peterson
- Status changed from verifying to closed
This is done correctly.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5198
MER11837 grouped