Ticket #4368 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Add a cppcheck target

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: minor Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Since it is on the build servers, make it a simple matter of people running "make cppcheck". This will be a unix only feature as that is the only place cppcheck appears to exist.

Change History

comment:1 Changed 9 years ago by Peter Peterson

Adding cmake modules. Refs #4368.

These are taken, verbatim from ​http://github.com/rpavlik/cmake-modules

Changeset: 4c5b38b05177481483f374b35aa02a9b731e82c3

comment:2 Changed 9 years ago by Peter Peterson

Redid infrastructure for cppcheck. Refs #4368.

Changeset: 63361e293cbf262d968dc19992c8bb44ded79e4b

comment:3 Changed 9 years ago by Peter Peterson

Adding the use of the template type. Refs #4368.

Changeset: 979f0439ab1c54c5569f3acab5b36fdb13e09d52

comment:4 Changed 9 years ago by Peter Peterson

Adding support for ignore files. Refs #4368.

Changeset: ac72e053131158805207aba121e4335f4bab04a4

comment:5 Changed 9 years ago by Peter Peterson

Adding much of the project to cppcheck target. Refs #4368.

Changeset: 72dfd2332ee02ac6e38982f07e87ca1aed6ed4e3

comment:6 Changed 9 years ago by Peter Peterson

Removed debug print. Refs #4368.

Changeset: c12b4621a4a0b9506ea0dbb0b1bbb0a50ba13b29

comment:7 Changed 9 years ago by Peter Peterson

Print out cppcheck version and change error return code. Refs #4368.

Changeset: a8bf5dde0a17c4ad02b6d9ddd21d514fbb8e2aa8

comment:8 Changed 9 years ago by Peter Peterson

Added explicit ignore files. Refs #4368.

Changeset: e3696dad7950cf16939bef421579511919d6db5b

comment:9 Changed 9 years ago by Peter Peterson

Change how files are ignored. Refs #4368.

Changeset: d039d44a7537d9881e942c4dbb4aef0824e54c7c

comment:10 Changed 9 years ago by Peter Peterson

Hopefully fixes up the paths in the jenkins report. Refs #4368.

Changeset: 532cbb2094e4f28fbd50c4efecb2963c2bd7c820

comment:11 Changed 9 years ago by Peter Peterson

Fixed string replacement. Refs #4368.

Changeset: d27c9c64ef2445b739a24594baae503393632ee7

comment:12 Changed 9 years ago by Peter Peterson

Add target's inc directory to cppcheck. Refs #4368.

Changeset: 42babb5d1a8d616730a35df8af5cc54b40ceb97a

comment:13 Changed 9 years ago by Peter Peterson

Adding more to cppcheck. Refs #4368.

Changeset: 035a9bed71198b509cd5d656a5277bd8f8498458

comment:14 Changed 9 years ago by Peter Peterson

Added more onto the include path. Refs #4368.

Changeset: 47dc8ee03b4b78288e71226ce7815d7b3acc219c

comment:15 Changed 9 years ago by Peter Peterson

Have to have absolute path. Refs #4368.

Changeset: 36f9f868d65650b2fea029cd6b9c32a0cff2168c

comment:16 Changed 9 years ago by Peter Peterson

Added option for number of cppcheck threads. Refs #4368.

Changeset: f52184d93019d40e4342bcecb986294e300b5721

comment:17 Changed 9 years ago by Peter Peterson

Made a new version of cppcheck target. Refs #4368.

Changeset: 60502b18cf23a4fbc0757570a08aca6b08131b0b

comment:18 Changed 9 years ago by Peter Peterson

Updating excludes. Refs #4368.

Changeset: d1007c48d0cabd26b6d8860643f12e8068462b3e

comment:19 Changed 9 years ago by Peter Peterson

Moving to the new style cppcheck target. Refs #4368.

Changeset: 7baf7aff25e499748f9fee3cfd9477f89e6127f4

comment:20 Changed 9 years ago by Peter Peterson

Making the final command similar to the working one. Refs #4368.

Changeset: 6ce95b0a93071ff7a9703a80396090404a4ee900

comment:21 Changed 9 years ago by Peter Peterson

Make using cppcheck include path option (default off). Refs #4368.

Changeset: 6520292cd859d0290bc3f50602d9dea2315e34bc

comment:22 Changed 9 years ago by Peter Peterson

Stop doublechecking. Refs #4368.

Changeset: c93f72cb70ac43954fe50e8ac1f9d2231b48c6b6

comment:23 Changed 9 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:24 Changed 9 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

I'm calling this one 'done'.

comment:25 Changed 9 years ago by Peter Peterson

Put back in cppcheck version message. Refs #4368.

Changeset: 6eab3a5403e02b6b5c49f3ec2bafc6e83bfd7d1f

comment:26 Changed 9 years ago by Stuart Campbell

Enable inline suppression by default. refs #4368 & #3868

Changeset: 4fc2c13fc593c6f3b975c803bef9c520750aa1ca

comment:27 Changed 9 years ago by Stuart Campbell

Enable inline suppression by default. refs #4368 & #3868

Changeset: 4b72942f594f5023fb215b51d0e7e7fb80079415

comment:28 Changed 9 years ago by Stuart Campbell

Enable inline suppression by default. refs #4368 & #3868

Fix the stupid syntax for cmake.

Changeset: e323e5cffa048b08ad204694af76e13c5e511045

comment:29 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:30 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

This works just fine on RHEL6.

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5215

Note: See TracTickets for help on using tickets.