Ticket #4401 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

IImplementation of ConvertToMD workspace algorithm

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.1
Component: VATES Keywords:
Cc: Blocked By: #4813
Blocking: Tester: Roman Tolchenov

Description

Algorithm exists and works both for matrix workspace and event workspace but number of substantial improvements/additions still needed.

1) Adding new data to existing workspace

2) Current events are treated using dynamic rebinning -- it may be what is needed for ISIS but may be not and is probably not acceptable for SNS. 3) More tests to verify if everything works correctly still needed (comparison with Horace).

4) Rotating crystal and more general&correct treatment of time logs used as a dimension.

5) Optimization and parallelisation

Change History

comment:1 Changed 9 years ago by Alex Buts

  • Status changed from new to assigned
  • Owner set to Alex Buts

comment:2 Changed 9 years ago by Alex Buts

  • Status changed from assigned to accepted

comment:3 Changed 9 years ago by Alex Buts

refs #4401 MDEventWSWrapper made reenterable

As boost function pointers do funny things when stings supplied as function arguments and when the number of arguments is high, custom vftable has been build with functions, which use 0 or 1 argument. As the result, internal memory for the class was needed.

Reverting to classic old function pointers allows to use multiple function arguments and eliminate the need for internal class memory. This allows to deploy const methods and makes class reenterable (mainly)

Changeset: 2aa3339a681eb512f1b8858e52d7d40a2b741410

comment:4 Changed 9 years ago by Alex Buts

refs #4401 Fixing Unix error

Changeset: 2587a936d6ba1418cbc77ec260ded6ccf480136b

comment:5 Changed 9 years ago by Alex Buts

refs #4401 attempt to fix unix error

Changeset: ddcc45f1959f1a26fedfff7a125945dd3caff233

comment:6 Changed 9 years ago by Alex Buts

  • Blocked By 4813 added

comment:7 Changed 9 years ago by Alex Buts

refs #4401 Starting the work on adding events to existing ws

Changeset: c159e1ce30fd9281c1cb4df295a474e69db944ca

comment:8 Changed 9 years ago by Alex Buts

refs #4401 MDEventWSWrapper made reenterable

As boost function pointers do funny things when stings supplied as function arguments and when the number of arguments is high, custom vftable has been build with functions, which use 0 or 1 argument. As the result, internal memory for the class was needed.

Reverting to classic old function pointers allows to use multiple function arguments and eliminate the need for internal class memory. This allows to deploy const methods and makes class reenterable (mainly)

Changeset: 2aa3339a681eb512f1b8858e52d7d40a2b741410

comment:9 Changed 9 years ago by Alex Buts

refs #4401 Fixing Unix error

Changeset: 2587a936d6ba1418cbc77ec260ded6ccf480136b

comment:10 Changed 9 years ago by Alex Buts

refs #4401 attempt to fix unix error

Changeset: ddcc45f1959f1a26fedfff7a125945dd3caff233

comment:11 Changed 9 years ago by Alex Buts

refs #4401 Starting the work on adding events to existing ws

Changeset: c159e1ce30fd9281c1cb4df295a474e69db944ca

comment:12 Changed 9 years ago by Alex Buts

refs #4401 Removed unused methods.

Changeset: bacc8c7e45f1c93658862faf421881795f842498

comment:13 Changed 9 years ago by Alex Buts

refs #4401 Removed redundant methods

Changeset: 329ecc20148daf372e9d8c2af16b575991c91210

comment:14 Changed 9 years ago by Alex Buts

refs #4401 Removed unused methods.

Changeset: bacc8c7e45f1c93658862faf421881795f842498

comment:15 Changed 9 years ago by Alex Buts

refs #4401 Removed redundant methods

Changeset: 329ecc20148daf372e9d8c2af16b575991c91210

comment:16 Changed 9 years ago by Alex Buts

refs #4401 Code refactored to separate different parts

of the code into different pieces, which are much less connected with each other.

Changeset: 4bd322c30c192e3f1f7f0af7a568311a01202250

comment:17 Changed 9 years ago by Alex Buts

refs #4401 further separating algorithm body from internal methods

Changeset: 6878d9270023653863d8791e427d8f596b7d7866

comment:18 Changed 9 years ago by Alex Buts

refs #4401 Fixing unix error.

Changeset: e5aa854e7024385c563914269b2e1cc5df7e701f

comment:19 Changed 9 years ago by Alex Buts

refs #4401 more tests for MDEventsSubalgorithm factory

Clearer metaloops which initiate the algorithms as the result.

Changeset: e14786b14818b864b54c36a79d65f66b30e6e38c

comment:20 Changed 9 years ago by Alex Buts

refs #4401 minor edits and comments

Changeset: 24b12e729d96b16df822535b2d05c4d1aff35850

comment:21 Changed 9 years ago by Alex Buts

refs #4401 Added Powder mode (without any functionality yet)

Compiles, test should not pass.

Changeset: 48cf3a1f188e1c00ea5828856a1e3599aed5a015

comment:22 Changed 9 years ago by Alex Buts

refs #4401 Passing existing tests for Conv2MD

Changeset: 5937bace257e8b08193641af702ddfbad7619f88

comment:23 Changed 9 years ago by Alex Buts

refs #4401 fixing unix error

Changeset: 5b061477d8cfc362619127bdb927a57002280121

comment:24 Changed 9 years ago by Alex Buts

refs #4401 Fixing Ctest error

Changeset: d2efb48e22e7ece205098b7346479ea3d452e9d6

comment:25 Changed 9 years ago by Alex Buts

refs #4401 Fixing unix warnings

Changeset: 71715a12f81632453cfdcd88db409c59ebee0f41

comment:26 Changed 9 years ago by Alex Buts

refs #4401 Code refactored to separate different parts

of the code into different pieces, which are much less connected with each other.

Changeset: 4bd322c30c192e3f1f7f0af7a568311a01202250

comment:27 Changed 9 years ago by Alex Buts

refs #4401 further separating algorithm body from internal methods

Changeset: 6878d9270023653863d8791e427d8f596b7d7866

comment:28 Changed 9 years ago by Alex Buts

refs #4401 Fixing unix error.

Changeset: e5aa854e7024385c563914269b2e1cc5df7e701f

comment:29 Changed 9 years ago by Alex Buts

refs #4401 more tests for MDEventsSubalgorithm factory

Clearer metaloops which initiate the algorithms as the result.

Changeset: e14786b14818b864b54c36a79d65f66b30e6e38c

comment:30 Changed 9 years ago by Alex Buts

refs #4401 minor edits and comments

Changeset: 24b12e729d96b16df822535b2d05c4d1aff35850

comment:31 Changed 9 years ago by Alex Buts

refs #4401 Added Powder mode (without any functionality yet)

Compiles, test should not pass.

Changeset: 48cf3a1f188e1c00ea5828856a1e3599aed5a015

comment:32 Changed 9 years ago by Alex Buts

refs #4401 Passing existing tests for Conv2MD

Changeset: 5937bace257e8b08193641af702ddfbad7619f88

comment:33 Changed 9 years ago by Alex Buts

refs #4401 fixing unix error

Changeset: 5b061477d8cfc362619127bdb927a57002280121

comment:34 Changed 9 years ago by Alex Buts

refs #4401 Fixing Ctest error

Changeset: d2efb48e22e7ece205098b7346479ea3d452e9d6

comment:35 Changed 9 years ago by Alex Buts

refs #4401 Fixing unix warnings

Changeset: 71715a12f81632453cfdcd88db409c59ebee0f41

comment:36 Changed 9 years ago by Alex Buts

refs #4401 changed uint64 to size_t to avoid win32 warnings.

The variable in question relates to ws in memory anyway

Changeset: d800549f562a74b0f965cafe174207f2acbc2ce6

comment:37 Changed 9 years ago by Alex Buts

refs #4401 changed get_vector to getVector

refs #4813 further step in separating transformation matrix from ConvertToMDEvents

Changeset: f878850796feee35f7ed07c40dabfc36704e3a87

comment:38 Changed 9 years ago by Alex Buts

refs #4401 Implemented adding to existing MDWS

Crudest implementation. no big checks for validity done.

Changeset: e7a29b6f4c291edb8729d4a31e0c6a7600a47108

comment:39 Changed 9 years ago by Alex Buts

refs #4401 Fixing unix warning

Changeset: fe77ab395579b2338c551b409ea1ceace840b38d

comment:40 Changed 8 years ago by Alex Buts

refs #4401 fixed bug with adding events to existing workspace

Changeset: 1be67aaee1e9a26d792084962225d3c8dc2c789e

comment:41 Changed 8 years ago by Alex Buts

refs #4401 Fixed error with copying additional WS parameters

when running add to existing MDWorkspace.

Changeset: f1965a1eaa81113573c3d6378c570594d3dc9bd5

comment:42 Changed 8 years ago by Alex Buts

refs #4401 fixed bug with adding events to existing workspace

Changeset: 1be67aaee1e9a26d792084962225d3c8dc2c789e

comment:43 Changed 8 years ago by Alex Buts

refs #4401 Fixed error with copying additional WS parameters

when running add to existing MDWorkspace.

Changeset: f1965a1eaa81113573c3d6378c570594d3dc9bd5

comment:44 Changed 8 years ago by Alex Buts

refs #4401 modified the sub-algorithms to obey code conversion.

Changeset: be399534e98afd5ff68a0cfaf9bc99624c61a08d

comment:45 Changed 8 years ago by Alex Buts

refs #4401 ConvertToMDEvent enums isolated into separate namespace

Changeset: 74aef192a8fdb88560be2ef8e897b159aed5e016

comment:46 Changed 8 years ago by Alex Buts

refs #4401 Added performance test

doing nothing for the time being

Changeset: afa94ee9cacb6c2c083e1ab384e40f7e73b7c6a4

comment:47 Changed 8 years ago by Alex Buts

refs #4401 Trying to fix Unix error

with template overloading/inheritance

Changeset: 27843f907e7b167b812adab7ede4302b9f2cdf1c

comment:48 Changed 8 years ago by Alex Buts

refs #4401 CTest test error fixed

Changeset: da20587a2bd687c6dc68a63c3be5cc6d7fd7a449

comment:49 Changed 8 years ago by Alex Buts

refs #4401 Trying to fix Unix error

Changeset: 1e5ecc608097734846efcfba28844fd8644e120d

comment:50 Changed 8 years ago by Alex Buts

refs #4401 Fixing (hopefully) Unix error

Changeset: c372a494cc1073d648560327a3afda34934504d4

comment:51 Changed 8 years ago by Alex Buts

refs #4401 Fixing CXX test error

Changeset: 41b065cc13b5ffd77a48c583d155fd10d1203842

comment:52 Changed 8 years ago by Alex Buts

refs #4401 Another attempt to resolve Unix namespace maze

Changeset: 69095483b943ba09eb6b31967b071cb707601cc5

comment:53 Changed 8 years ago by Alex Buts

refs #4401 looking for Unix error source

Changeset: 0b1d5d1116e543fc33e22a0706ec5627d1c6c8e0

comment:54 Changed 8 years ago by Alex Buts

refs #4401 wandering in Unix namspaces maze

Changeset: 2822a81a3572ff986a5cae10d502f09bfee14a52

comment:55 Changed 8 years ago by Alex Buts

refs #4401 reverting ConvertToMD namespace changes

as this seems not works on Unix properly

Changeset: 09cec3bcaa97ea05a2f422b8d7dce76bd5f82f0a

comment:56 Changed 8 years ago by Alex Buts

refs #4401 syntax error

Changeset: 0aca422ffe10f6363728b889d608c94ed5234856

comment:57 Changed 8 years ago by Alex Buts

refs #4401 trying again

Changeset: 027f3287e65d96fc54609be6df25cd84007c04e2

comment:58 Changed 8 years ago by Alex Buts

Revert "refs #4401 trying again"

This reverts commit dfaa10ba5d24e4c949cecc02dda90890dc293e1a.

Changeset: 4ad806f635363d43b770b72cfe22be4aac92de1f

comment:59 Changed 8 years ago by Alex Buts

refs #4401 trying to fix broken commin

Changeset: 29b04596cee801e0a6ba694d13e53935a91ed64e

comment:60 Changed 8 years ago by Alex Buts

refs #4401 trying to nail error

Changeset: 70277310f8e72bbbb5a5f1c83e3a4ab87394d18c

comment:61 Changed 8 years ago by Alex Buts

refs #4401 more attempts to corner Unix error

Changeset: 7a33301f681196f865465739a4236a1506c59ec5

comment:62 Changed 8 years ago by Alex Buts

refs #4401 still some compilation erros

Changeset: 4fd2962723064740f2407eca0455ee1846fd96fd

comment:63 Changed 8 years ago by Alex Buts

refs #4401 trying to disable all offending code

Changeset: c9bc454323287c7efe5c16e306b72291a432d5ad

comment:64 Changed 8 years ago by Alex Buts

refs #4401 Trying to disable all offending code

Changeset: 2acd679f9e361eae3546686a87b9a3e6f694bb11

comment:65 Changed 8 years ago by Alex Buts

refs #4401 disabling all offending code

Changeset: 94b141a81c2147fe9881eabe2f7e6263e626ed91

comment:66 Changed 8 years ago by Alex Buts

refs #4401 disabling all offending code

Changeset: b761b251332bc1d35584c22f16fc8b99f4eb0406

comment:67 Changed 8 years ago by Alex Buts

refs #4401 preprecessed detectors are prepared to refactoring

Changeset: 2dc8c40954d4042235c51b7924a24407511377be

comment:68 Changed 8 years ago by Alex Buts

refs #4401 enabling part of the code

in hope that should be no errors on Unix

Changeset: cbf50c4321712f68ec48ad7f7ba0c0e5d6f2f851

comment:69 Changed 8 years ago by Alex Buts

refs #4401 minor comment

Changeset: c64c86169a3df46190e22e830b7690f3a5393cb0

comment:70 Changed 8 years ago by Alex Buts

refs #4401 Another piece of refactored code added

and hopefully works

Changeset: 0af0063fc0eecd1e77249449c70daa54b3d5fb38

comment:71 Changed 8 years ago by Alex Buts

refs #4401 Another piece of TM code added back

Changeset: a9941716154a8b1c1bedcb552e5e6e4e9c4dbe56

comment:72 Changed 8 years ago by Alex Buts

refs #4401 Fixing Unix warning

Changeset: 3264ec3197e50bd7903c0cbd2f2de18d1cfdc7c0

comment:73 Changed 8 years ago by Alex Buts

refs #4401 Additional piece of code enabled

Changeset: 7315ed74296a916c940b06d80dd187d9bafd0a54

comment:74 Changed 8 years ago by Alex Buts

refs #4401 enabled all failing code under win

Changeset: 91e4acd818e8831e30c716e909386ad3f3f5bc9c

comment:75 Changed 8 years ago by Alex Buts

refs #4401 missed modification added

Changeset: 0719e619ba63269e4952f55f95406f04dafc7deb

comment:76 Changed 8 years ago by Alex Buts

refs #4401 Enabled everything disabled before.

Should be in working order now.

Changeset: b38a65480153b16949475b0fff0dfeeb8d8a457f

comment:77 Changed 8 years ago by Alex Buts

refs #4401 this should return code to working state

Changeset: 167a1859e662c3cec01ccd2afd39a40b952bc982

comment:78 Changed 8 years ago by Alex Buts

refs #4401 minor error fixed

Changeset: 18b1e680faf2d6d7a8875f226d12c1ef87f1e8a8

comment:79 Changed 8 years ago by Alex Buts

refs #4401 dim names and dimID-s were switching places.

Changeset: e9384d7625029ee12f4f78b6ad262b9e495bb32b

comment:80 Changed 8 years ago by Alex Buts

refs #4401 Minor bugs in WS description

not all fixed

Changeset: d52291ad70d1ff681a80c39a3ca8761596be0f23

comment:81 Changed 8 years ago by Alex Buts

refs #4401 explicitly extracted interfaces on biggest subalg classes

Changeset: 25244bf7ec5016f9a424662d00a09cfc4693944b

comment:82 Changed 8 years ago by Alex Buts

refs #5161 detectors clear behind themselves

refs #4401 a performance test skeleton

Changeset: 81dba05c570df4019b206ee7920f73cf426cd935

comment:83 Changed 8 years ago by Alex Buts

refs #4401 added couple of performance tests which check something

can not compare results as the results widely differ on test data provided.

Changeset: a0ecde9e3e699a080cb8a4da12e17164bab4808e

comment:84 Changed 8 years ago by Alex Buts

4) Rotating crystal and more general&correct treatment of time logs used as a dimension have not been touched but otherwise -- pretty large changes to implementation.

Parallel is also postponed as questions about adding to MD workspace in parallel remain.

Number of possible optimization tasks remain but can deal with it after design discussion.

comment:85 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:86 Changed 8 years ago by Alex Buts

refs #4401 modified the sub-algorithms to obey code conversion.

Changeset: be399534e98afd5ff68a0cfaf9bc99624c61a08d

comment:87 Changed 8 years ago by Alex Buts

refs #4401 ConvertToMDEvent enums isolated into separate namespace

Changeset: 74aef192a8fdb88560be2ef8e897b159aed5e016

comment:88 Changed 8 years ago by Alex Buts

refs #4401 Added performance test

doing nothing for the time being

Changeset: afa94ee9cacb6c2c083e1ab384e40f7e73b7c6a4

comment:89 Changed 8 years ago by Alex Buts

refs #4401 Trying to fix Unix error

with template overloading/inheritance

Changeset: 27843f907e7b167b812adab7ede4302b9f2cdf1c

comment:90 Changed 8 years ago by Alex Buts

refs #4401 CTest test error fixed

Changeset: da20587a2bd687c6dc68a63c3be5cc6d7fd7a449

comment:91 Changed 8 years ago by Alex Buts

refs #4401 Trying to fix Unix error

Changeset: 1e5ecc608097734846efcfba28844fd8644e120d

comment:92 Changed 8 years ago by Alex Buts

refs #4401 Fixing (hopefully) Unix error

Changeset: c372a494cc1073d648560327a3afda34934504d4

comment:93 Changed 8 years ago by Alex Buts

refs #4401 Fixing CXX test error

Changeset: 41b065cc13b5ffd77a48c583d155fd10d1203842

comment:94 Changed 8 years ago by Alex Buts

refs #4401 Another attempt to resolve Unix namespace maze

Changeset: 69095483b943ba09eb6b31967b071cb707601cc5

comment:95 Changed 8 years ago by Alex Buts

refs #4401 looking for Unix error source

Changeset: 0b1d5d1116e543fc33e22a0706ec5627d1c6c8e0

comment:96 Changed 8 years ago by Alex Buts

refs #4401 wandering in Unix namspaces maze

Changeset: 2822a81a3572ff986a5cae10d502f09bfee14a52

comment:97 Changed 8 years ago by Alex Buts

refs #4401 reverting ConvertToMD namespace changes

as this seems not works on Unix properly

Changeset: 09cec3bcaa97ea05a2f422b8d7dce76bd5f82f0a

comment:98 Changed 8 years ago by Alex Buts

refs #4401 syntax error

Changeset: 0aca422ffe10f6363728b889d608c94ed5234856

comment:99 Changed 8 years ago by Alex Buts

refs #4401 trying again

Changeset: 027f3287e65d96fc54609be6df25cd84007c04e2

comment:100 Changed 8 years ago by Alex Buts

Revert "refs #4401 trying again"

This reverts commit dfaa10ba5d24e4c949cecc02dda90890dc293e1a.

Changeset: 4ad806f635363d43b770b72cfe22be4aac92de1f

comment:101 Changed 8 years ago by Alex Buts

refs #4401 trying to fix broken commin

Changeset: 29b04596cee801e0a6ba694d13e53935a91ed64e

comment:102 Changed 8 years ago by Alex Buts

refs #4401 trying to nail error

Changeset: 70277310f8e72bbbb5a5f1c83e3a4ab87394d18c

comment:103 Changed 8 years ago by Alex Buts

refs #4401 more attempts to corner Unix error

Changeset: 7a33301f681196f865465739a4236a1506c59ec5

comment:104 Changed 8 years ago by Alex Buts

refs #4401 still some compilation erros

Changeset: 4fd2962723064740f2407eca0455ee1846fd96fd

comment:105 Changed 8 years ago by Alex Buts

refs #4401 trying to disable all offending code

Changeset: c9bc454323287c7efe5c16e306b72291a432d5ad

comment:106 Changed 8 years ago by Alex Buts

refs #4401 Trying to disable all offending code

Changeset: 2acd679f9e361eae3546686a87b9a3e6f694bb11

comment:107 Changed 8 years ago by Alex Buts

refs #4401 disabling all offending code

Changeset: 94b141a81c2147fe9881eabe2f7e6263e626ed91

comment:108 Changed 8 years ago by Alex Buts

refs #4401 disabling all offending code

Changeset: b761b251332bc1d35584c22f16fc8b99f4eb0406

comment:109 Changed 8 years ago by Alex Buts

refs #4401 preprecessed detectors are prepared to refactoring

Changeset: 2dc8c40954d4042235c51b7924a24407511377be

comment:110 Changed 8 years ago by Alex Buts

refs #4401 enabling part of the code

in hope that should be no errors on Unix

Changeset: cbf50c4321712f68ec48ad7f7ba0c0e5d6f2f851

comment:111 Changed 8 years ago by Alex Buts

refs #4401 minor comment

Changeset: c64c86169a3df46190e22e830b7690f3a5393cb0

comment:112 Changed 8 years ago by Alex Buts

refs #4401 Another piece of refactored code added

and hopefully works

Changeset: 0af0063fc0eecd1e77249449c70daa54b3d5fb38

comment:113 Changed 8 years ago by Alex Buts

refs #4401 Another piece of TM code added back

Changeset: a9941716154a8b1c1bedcb552e5e6e4e9c4dbe56

comment:114 Changed 8 years ago by Alex Buts

refs #4401 Fixing Unix warning

Changeset: 3264ec3197e50bd7903c0cbd2f2de18d1cfdc7c0

comment:115 Changed 8 years ago by Alex Buts

refs #4401 Additional piece of code enabled

Changeset: 7315ed74296a916c940b06d80dd187d9bafd0a54

comment:116 Changed 8 years ago by Alex Buts

refs #4401 enabled all failing code under win

Changeset: 91e4acd818e8831e30c716e909386ad3f3f5bc9c

comment:117 Changed 8 years ago by Alex Buts

refs #4401 missed modification added

Changeset: 0719e619ba63269e4952f55f95406f04dafc7deb

comment:118 Changed 8 years ago by Alex Buts

refs #4401 Enabled everything disabled before.

Should be in working order now.

Changeset: b38a65480153b16949475b0fff0dfeeb8d8a457f

comment:119 Changed 8 years ago by Alex Buts

refs #4401 this should return code to working state

Changeset: 167a1859e662c3cec01ccd2afd39a40b952bc982

comment:120 Changed 8 years ago by Alex Buts

refs #4401 minor error fixed

Changeset: 18b1e680faf2d6d7a8875f226d12c1ef87f1e8a8

comment:121 Changed 8 years ago by Alex Buts

refs #4401 dim names and dimID-s were switching places.

Changeset: e9384d7625029ee12f4f78b6ad262b9e495bb32b

comment:122 Changed 8 years ago by Alex Buts

refs #4401 Minor bugs in WS description

not all fixed

Changeset: d52291ad70d1ff681a80c39a3ca8761596be0f23

comment:123 Changed 8 years ago by Alex Buts

refs #4401 explicitly extracted interfaces on biggest subalg classes

Changeset: 25244bf7ec5016f9a424662d00a09cfc4693944b

comment:124 Changed 8 years ago by Alex Buts

refs #5161 detectors clear behind themselves

refs #4401 a performance test skeleton

Changeset: 81dba05c570df4019b206ee7920f73cf426cd935

comment:125 Changed 8 years ago by Alex Buts

refs #4401 added couple of performance tests which check something

can not compare results as the results widely differ on test data provided.

Changeset: a0ecde9e3e699a080cb8a4da12e17164bab4808e

comment:126 Changed 8 years ago by Alex Buts

refs #4401 Added provisional UML diagram for existing ConvertToMDEvent algorithms bunch

not complete diagram

Changeset: c9245d374377c9d875fc05a17c4ad4762daaa126

comment:127 Changed 8 years ago by Alex Buts

refs #4401 Minor Comments

Changeset: fb1c570f2d54b08dd80b4791559edba59791e038

comment:128 Changed 8 years ago by Alex Buts

refs #4401 Minor Comments

Changeset: 09a7eda15274e6bd0db855fe7da7bd7b51a4f715

comment:129 Changed 8 years ago by Alex Buts

Testers should check if algorithm adds to existing workspace correctly.

and (ideally :) if the structure of the super-algorithm is understandable.

comment:130 Changed 8 years ago by Alex Buts

refs #4401 Comments to properties

synchronized with new meaning and wiki

Changeset: fe783e4c9d9f148fcc56f9857c8fdb520885f1ea

comment:131 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:132 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Checked by running the algorithm in the GUI and running a test script.

comment:133 Changed 8 years ago by Alex Buts

refs #4401 Minor Comments

Changeset: 09a7eda15274e6bd0db855fe7da7bd7b51a4f715

comment:134 Changed 8 years ago by Alex Buts

refs #4401 Comments to properties

synchronized with new meaning and wiki

Changeset: fe783e4c9d9f148fcc56f9857c8fdb520885f1ea

comment:135 Changed 8 years ago by Alex Buts

refs #4401 UML for recent MD workspace implementation

Changeset: 634a286ffbdf8ba6d409ad2ff87f179ac3983681

comment:136 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5248

Note: See TracTickets for help on using tickets.