Ticket #4409 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

TimeSeriesProperty: Improve unit test coverage

Reported by: Russell Taylor Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The following method in TimeSeriesProperty are lacking a unit test:

  • clone
  • getMemorySize
  • merge
  • setName
  • valueAsCorrectMap
  • valuesAsVector
  • lastTime
  • firstValue
  • firstTime
  • value
  • time_tValue
  • valueAsMap
  • create
  • nthTime
  • lastValue
  • nthInterval
  • filterWith
  • clearFilter
  • countSize
  • isTimeString
  • isValid
  • isDefault

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anyone

comment:2 Changed 9 years ago by Peter Peterson

  • Owner changed from Anyone to Wenduo Zhou

comment:3 Changed 9 years ago by Wenduo Zhou

  • Status changed from assigned to accepted

comment:4 Changed 9 years ago by Wenduo Zhou

Add more unit tests. Refs #4409.

Changeset: 48ddec48a0f1ecf9617ce598780bc7d1ab7a4fcb

comment:5 Changed 9 years ago by Wenduo Zhou

Complete unit tests. Refs #4409.

Changeset: 33353eb442086d4fd977a556fbe6178895330974

comment:6 Changed 9 years ago by Wenduo Zhou

Complete unit tests. Refs #4409.

Changeset: 33353eb442086d4fd977a556fbe6178895330974

comment:7 Changed 9 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:9 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

A few minor corrections:

  • There isn't an explicit test for valuesAsVector, but it is used in several other tests. Add one for it directly since so much depends on it.
  • valueAsCorrecMap has incorrect documentation.
  • isValid is not tested
  • isDefault is not tested

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

comment:11 Changed 8 years ago by Wenduo Zhou

Add more unit tests. Refs #4409.

Changeset: a1980e58fcc2bee6cdd35530e686f713332c373a

comment:12 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:13 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 8 years ago by Wenduo Zhou

Add more unit tests. Refs #4409.

Changeset: 7fee3f8bae2bb8f5e5acf5b793d12269c80b0a50

comment:15 Changed 8 years ago by Wenduo Zhou

  • Milestone changed from Release 2.2 to Release 2.1

comment:16 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Peter Peterson to Andrei Savici

comment:17 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:18 Changed 8 years ago by Wenduo Zhou

Add more unit tests. Refs #4409.

Changeset: 7fee3f8bae2bb8f5e5acf5b793d12269c80b0a50

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5256

Note: See TracTickets for help on using tickets.