Ticket #4463 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Load: Progress reporting erratic for MERLIN data

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: major Milestone: Release 2.3
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

Loading data from
isis\inst$\NDXMERLIN\Instrument\data\cycle_11_4 picking .raw data file of size about 200MB sometimes the processbar behaves well and sometimes not.

When not behaving well then progress is 0% for about 30 sec and than 100%. Note for loading the same dataset MERLIN11844.raw I have managed to observed both behaviours.

1) see if you can observe the same behaviour on your computer (if not we try on mine)

2) improve this

Change History

comment:1 Changed 9 years ago by Karl Palmen

  • Summary changed from Load: Progress reporting irratic for MERLIN data to Load: Progress reporting erratic for MERLIN data

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:4 Changed 8 years ago by Karl Palmen

I've observed a similar problem when loading an ISIS Nexus file while dealing with ticket #3445. It seems the progress management of the subalgorithm LoadInstrument is not working.

comment:5 Changed 8 years ago by Karl Palmen

It seems that the progress reporting in the LoadInstrument sub algorithm needs activating to work. This is for the LoadRaw subalgorithm by Load::setUpLoader() with the code

      if (startProgress >= 0. && endProgress > startProgress && endProgress <= 1.)
      {
        loader->addObserver(m_progressObserver);
        setChildStartProgress(startProgress);
        setChildEndProgress(endProgress);
      }

I'll try adding this to the code that invokes the LoadInstrument subalgorithm.

comment:6 Changed 8 years ago by Karl Palmen

  • Status changed from new to accepted

comment:7 Changed 8 years ago by Karl Palmen

Enable some subalgorithms to report progress re #4463

This has improved progress reporting, but there is still work to do, particularly modifying the progress range of LoadRaw3, so that it starts where the instrument loading has finished rather than 0%.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4a0ce07eebef9ce64553eb5f13b2c2d2cd67d33e

comment:8 Changed 8 years ago by Karl Palmen

Made progress continuous from loading instrument to data re #4463

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 55799a10746855ad6b9ea6d8a5eb4d08e50024c7

comment:9 Changed 8 years ago by Karl Palmen

More improvements of progress reporting in loading raw files re #4463

In particular LoadRawHelper::LoadLog has been told where it is in the progress not to disrupt the progress bar.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 101f617be38e431426ef10a7df6fc4b57077e0cd

comment:10 Changed 8 years ago by Karl Palmen

There is room for further improvement and similar issues apply to loading ISIS Nexus files and possibly other kinds of files.

comment:11 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:13 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to closed

Tested for MERLIN 12979, 12894, 7747, for GEM 60297 and for SANS2D 14751, inside Windows and Ubuntu 12.4.

In Ubuntu the performance is worse. Some times, it seems that the application hangs on the Load Dialog interface. But the progress bar in all cases performs correctly.

comment:14 Changed 8 years ago by Karl Palmen

Enable some subalgorithms to report progress re #4463

This has improved progress reporting, but there is still work to do, particularly modifying the progress range of LoadRaw3, so that it starts where the instrument loading has finished rather than 0%.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4a0ce07eebef9ce64553eb5f13b2c2d2cd67d33e

comment:15 Changed 8 years ago by Karl Palmen

Made progress continuous from loading instrument to data re #4463

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 55799a10746855ad6b9ea6d8a5eb4d08e50024c7

comment:16 Changed 8 years ago by Karl Palmen

More improvements of progress reporting in loading raw files re #4463

In particular LoadRawHelper::LoadLog has been told where it is in the progress not to disrupt the progress bar.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 101f617be38e431426ef10a7df6fc4b57077e0cd

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5310

Note: See TracTickets for help on using tickets.