Ticket #4482 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

StripVanadiumPeak fails on NOMAD data

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: peter, peterson Blocked By:
Blocking: Tester: Peter Peterson

Description

StripVanadiumPeak() cannot render a correct result on NOMAD data.

Try: sam=2156, back=2059, van=2060. Get 30 seconds run to avoid memory issue.

Change History

comment:1 Changed 9 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Wenduo Zhou

Add option of tolerance. Refs #4482.

Changeset: 3cb92d1af4c23a89f5ed9d82f8a82390e31255b3

comment:3 Changed 9 years ago by Wenduo Zhou

  • Milestone changed from Iteration 33 to Iteration 32

comment:4 Changed 9 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Wenduo Zhou

Modify input options. Refs #4482.

Changeset: 962c8c6ba56329295b81c3d50bbc5b28ce2cc0b9

comment:6 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:7 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to closed

This was done correctly.

comment:8 Changed 9 years ago by Wenduo Zhou

Make StripPeaks more robust. Refs #4482.

Add one more criteria, PeakHeightTolerance, to FindPeaks(), such that any peak found with peak's fitted height larger than tolerance (proportional to local maximum without background) will be treated as a bad fit.

Changeset: d45adf255826b77b513a0e690586ea172bf92f53

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5329

Note: See TracTickets for help on using tickets.