Instrument View is really slow for TOPAZ (again)

[Janik Zikovsky]

I remember parallelizing it to speed up the TOPAZ instrument view but it is using a single core. Speed it up. It currently takes 10+ seconds to pop up a TOPAZ view, and whenever you change the color scale.

[Janik Zikovsky]

Refs #4484: Significant speed improvement of instrument view

for TOPAZ, but this is still limited by the resetColors() method looking for masked detectors.

Changeset: 0fe39905c34a66493d75b699177de393c6022e2e

[Janik Zikovsky]

Refs #4484: an attempt to speed up that does not work

Changeset: 9122492f60bbef07e714c912a01145b16c8776cc

[Janik Zikovsky]

Refs #4484 fixed isDetectorMasked and added unit test

Used the method in plotting for a good speed up

Changeset: b7c07332f9b8a9a24bd9e1dc569cf378cba2db35

[Janik Zikovsky]

Refs #4484 pick detectors is faster but opening window is slow again

by caching. Will make it cache only when needed.

Changeset: 7c565470caadce79f1920c7837b852d6c5936487

[Janik Zikovsky]

Refs #4484: fix isDetectorMasked for groups

... all detectors have to be masked to return true

Changeset: 0904544229699f2c455d004bcee1a5812c755ab7

[Janik Zikovsky]

Refs #4484: instrument window view, pick and apply mask is much faster

By caching detector position once instead of calculating each time.

Changeset: e2a2582e075b4cdbc0f8c8fe852754824219d507

[Janik Zikovsky]

Refs #4484 a much faster getDetectorIDToWorkspaceIndexVector method

Changeset: 5f00ec7c2d505f987884efc11d202a63d36bbcbb

[Janik Zikovsky]

Refs #4484 opening the instrument window is 3x faster than last commit

And about 10x faster than initial (15 seconds down to 1.4 seconds) Removed some really slow, do-nothing code! isDetectorMasked() again dominates the time

Changeset: 1c19797be37dee12992a3a92641316e3ffb06de7

[Janik Zikovsky]

OK the instrument view is MUCH faster than before. The remaining speed up would be in masking, see ticket #4759.

[Janik Zikovsky]

Note to testers: try release 2.0.0 and compare current. Open a TOPAZ file or other instrument with lots of detectors (e.g. SNAP) in the instrument view. It should be way faster.

[Janik Zikovsky]

Refs #4484: log instead of throw when faced with invalid detector ID

in MatrixWorkspace::getDetectorIDToWorkspaceIndexVector(), which is called in the instrument view

Changeset: 77e34ea54d9e32336b7dbca5b25731cdc3337eda

[Dennis Mikkelson]

Works fine on Linux, Windows 7-64 bit, and Snow Leopard.

[Stuart Campbell]

This ticket has been transferred to github issue ​5331