Ticket #4487 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Instrument View: Peak overlay in unwrapped view is super slow for TOPAZ

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: pf9@…, vel@… Blocked By:
Blocking: Tester: Dennis Mikkelson

Description

UnwrappedSurface.cpp around line 677. Looks like a loop over EVERY detector for EVERY peak!? No wonder this is slow.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Summary changed from Peak overlay in unwrapped instrument view is super slow for TOPAZ to Instrument View: Peak overlay in unwrapped view is super slow for TOPAZ

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4487: speed up peak overlay display by 16000x for TOPAZ

16.6 seconds -> 1 msec, nice :)

Changeset: 30a21e406d24cde51609768b87f3e70cb079af20

comment:4 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note to testers: load/make a PeaksWorkspace and drag-drop into the Instrument View window in unwrapped mode. It should now be quick.

comment:5 Changed 8 years ago by Dennis Mikkelson

  • Status changed from verify to verifying
  • Tester set to Dennis Mikkelson

comment:6 Changed 8 years ago by Dennis Mikkelson

  • Status changed from verifying to closed

Works fine on Linux and Mac, still slow on Windows 7. See ticket #5233 for next iteration.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5334

Note: See TracTickets for help on using tickets.