Ticket #4493 (closed: fixed)
Create CompareMDWorkspaces
| Reported by: | Owen Arnold | Owned by: | Janik Zikovsky |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | VATES | Keywords: | |
| Cc: | nick.draper@… | Blocked By: | |
| Blocking: | Tester: | Owen Arnold |
Description
We have a CheckWorkspacesMatch algorithm* for MatrixWorkspaces. It would be very useful to have a MD equivalent, capable of operating on any IMDWorkspace. In particular it should have options to check the box structure. This would be a useful thing to run prior to MergeMD.
It would also be nice to compare dimensionality etc.
*My natural instinct is actually always to look for a CompareWorkspaces algorithm when looking for this algorithm
Change History
comment:2 Changed 9 years ago by Owen Arnold
If it's okay with Nick (he's also cc'd) on this ticket I think we should rename CheckWorkspacesMatch to CompareWorkspaces as it's a more natural naming. I'll see what he thinks.
comment:3 Changed 9 years ago by Janik Zikovsky
- Status changed from new to accepted
- Summary changed from Create CheckMDWorkspacesMatch to Create CompareMDWorkspaces
comment:4 Changed 9 years ago by Janik Zikovsky
Refs #4493: CompareMDWorkspaces algorithm added.
Changeset: 1b970e0805d41a47d883ddcb20863635e247e15e
comment:5 Changed 9 years ago by Janik Zikovsky
Refs #4493 isThreadSafe() method for IMDEventworkspace
Changeset: 54bff321c6169a5787e2961a25ab8d5d668f2fff
comment:6 Changed 9 years ago by Janik Zikovsky
Refs #4493 mac linker fix, I hope
Changeset: ca19d031ccb0eb0b9b19c1c03d9451fc5f114855
comment:7 Changed 9 years ago by Martyn Gigg
Refs #4493. Mac linker fix.
Changeset: de6a0e0660f013e37d39beca9c7f2cc1ff1a730d
comment:8 Changed 9 years ago by Janik Zikovsky
Refs #4493 documentation for CompareMDWorkspaces
Changeset: 4bd9fcd5e4bfc9d75f6dada1f908c88a9ec99c55
comment:9 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
comment:10 Changed 8 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:11 Changed 8 years ago by Owen Arnold
- Status changed from verifying to closed
Seems to work fine. Unit tests also present and providing good coverage.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5340
Yes I was thinking the same thing. Comparing MDHistoWorkspaces will also be needed.
I also like the name CompareWorkspaces better. Maybe we could rename them and add an alias for CheckWorkspacesMatch...