Ticket #4499 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

DetectorEfficiency needs to average over the number of detectors within each spectrum

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

The algorithm currently corrects each spectrum by an efficiency factor based on the detector geometry of each contributing pixel within the group. For instruments where the number of pixels per group is different across the instrument you see a different overall correction for some parts of the instrument vs others.

See image attached of MERLIN. The shortubes are hardware grouped at 8:1 per spectrum whereas the long tubes are 4:1. The final pattern shows the obvious error in the region around the beam.

Attachments

MERLIN_ShortTubes.png (431.0 KB) - added by Martyn Gigg 9 years ago.

Change History

Changed 9 years ago by Martyn Gigg

comment:1 Changed 9 years ago by Martyn Gigg

Refs #4499. DetectorEfficiencyCor averages by the number in a group.

This fixes a bug that shows up in MERLIN where the hardware grouping is different on some tubes.

Changeset: d8a9d87527db7e52d84d169da7fc2b5ef3ce1e79

comment:2 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Martyn Gigg

Refs #4499. Update the test value.

Changeset: 93c79ca0e47271cf98db7253da1474ef1801b032

comment:5 Changed 9 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:6 Changed 9 years ago by Karl Palmen

  • Status changed from verifying to closed

Tested using Convert To Energy interface (1st tab)

Input Files: Runs:
isis\inst$\NDXMERLIN\Instrument\data\cycle_09_4\MER06398.raw

Conversion To Energy Transfer: Incident Energy: 18 Mev

Energy Transfer Range (MeV): -18, 0.1, 18

Output Options: Filename: MER06398.spe

Then show instrument of MER06398.spe

Test showed consistently coloured columns with some variation of colour.

comment:7 Changed 9 years ago by Martyn Gigg

Refs #4499. DetectorEfficiencyCor averages by the number in a group.

This fixes a bug that shows up in MERLIN where the hardware grouping is different on some tubes.

Changeset: d8a9d87527db7e52d84d169da7fc2b5ef3ce1e79

comment:8 Changed 9 years ago by Martyn Gigg

Refs #4499. Update the test value.

Changeset: 93c79ca0e47271cf98db7253da1474ef1801b032

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5346

Note: See TracTickets for help on using tickets.