Ticket #4501 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

selectMultiPeak doesn't work properly

Reported by: Mathieu Doucet Owned by: Roman Tolchenov
Priority: blocker Milestone: Release 2.0
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

The following code used to work. What should happen is that a new plot window is created, and the selectMultiPeak call would draw two blue dashed vertical lines to select a region on the graph. Those lines no longer appear.

plot("5732_frame1_Iq.xml",[0],True)
qti.app.selectMultiPeak(False)

Note: if you run the code twice, you will get the selection lines on the first graph you plotted. There seems to be a problem managing which window is the active window.

What we would really like to have is something like this:

g=plot("5732_frame1_Iq.xml",[0],True)
qti.app.selectMultiPeak(g)

Change History

comment:1 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Russell Taylor

Actually, I think that what we really want is:

 g=plot("5732_frame1_Iq.xml",[0],True)
 g.selectMultiPeak()  or  g.activeLayer().selectMultiPeak()

i.e. the method belongs to the object upon which its acting.

comment:3 Changed 9 years ago by Roman Tolchenov

Re #4501. Works again.

Changeset: 7e92934ed14b412b3ac3f1ee4b9f754bed2f390c

comment:4 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:6 Changed 9 years ago by Karl Palmen

  • Status changed from verifying to closed

Running

raw = Load('MAR11015')
plot("raw",1,True)
qti.app.selectMultiPeak(False)

lead to a graph with two blue range limits as required.

comment:7 Changed 9 years ago by Mathieu Doucet

  • Status changed from closed to reopened
  • Resolution fixed deleted

Still doesn't work on linux.

comment:8 Changed 9 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:9 Changed 9 years ago by Roman Tolchenov

Re #4501. Should work on linux now.

Changeset: 03b463e9569d3d6978ca93051b478f9774fbe6f6

comment:10 Changed 9 years ago by Roman Tolchenov

Changed selectMultiPeak(...) so it takes a MultiLayer and a bool. A testing code should look like this:

raw = Load('MAR11015','raw')
g = plot("raw",1,True)
selectMultiPeak(g,False)

comment:11 Changed 9 years ago by Mathieu Doucet

Re #4501 Change code to use new signature. Now works on linux

Changeset: 69109787580ee4f21d720179091e1a52b58fbab2

comment:12 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 9 years ago by Roman Tolchenov

Re #4501. Works again.

Changeset: 7e92934ed14b412b3ac3f1ee4b9f754bed2f390c

comment:14 Changed 9 years ago by Roman Tolchenov

Re #4501. Should work on linux now.

Changeset: 03b463e9569d3d6978ca93051b478f9774fbe6f6

comment:15 Changed 9 years ago by Mathieu Doucet

Re #4501 Change code to use new signature. Now works on linux

Changeset: 69109787580ee4f21d720179091e1a52b58fbab2

comment:16 Changed 9 years ago by Mathieu Doucet

Re #4501 Change code to use new signature. Now works on linux

Changeset: ea11882d0e78946ad16965df998d7400dffb0bc9

comment:17 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester changed from Karl Palmen to Janik Zikovsky

comment:18 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5348

Note: See TracTickets for help on using tickets.