Ticket #4519 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Muon: loose connection

Reported by: Robert Whitley Owned by: Robert Whitley
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

There is a signal that isn't connecting because there is no slot for it to connect to.

Remove this.

To test,

1) Make sure you have the most up to date build.

2) Run Mantid in Debug.

3) Open Muon Analysis.

4) Check the command line to see if the error has been printed.

Change History

comment:1 Changed 9 years ago by Robert Whitley

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Robert Whitley

Refs #4519. Remove connection between signal and non-existent slot.

Changeset: 1b8408a0081b20f9ab72dbf09cfcff17d28421e6

comment:3 Changed 9 years ago by Robert Whitley

Refs #4519. Remove connection for MuonAnalysis FitPropertyBrowser.

Changeset: f111325e5bbeded316283c8bfac7c533a59a1158

comment:4 Changed 9 years ago by Robert Whitley

I've included the connection in my second commit (after deleting it) because although MuonAnalysis doesn't use it another part of Mantid does.

The connection didn't form due to the mantid_ui not been passed in the case of MuonAnalysis. I have made it so that it will only form a connection when the FitPropertyBrowser is not part of a custom interface.

comment:5 Changed 9 years ago by Robert Whitley

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:7 Changed 9 years ago by Karl Palmen

No error seen in results log, scripting console or command window arising from opening muon analysis.

comment:8 Changed 9 years ago by Karl Palmen

  • Status changed from verifying to closed

comment:9 Changed 9 years ago by Robert Whitley

Refs #4519. Remove connection between signal and non-existent slot.

Changeset: 1b8408a0081b20f9ab72dbf09cfcff17d28421e6

comment:10 Changed 9 years ago by Robert Whitley

Refs #4519. Remove connection for MuonAnalysis FitPropertyBrowser.

Changeset: f111325e5bbeded316283c8bfac7c533a59a1158

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5366

Note: See TracTickets for help on using tickets.