Ticket #452 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Create an algorithm to scale PSDs according to an input file

Reported by: Nick Draper Owned by: Ronald Fowler
Priority: critical Milestone: Iteration 17
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Nick Draper) (diff)

We will need to talk to Rob Bewley to get a sample file for MERLIN. Then we will need to apply this to the instrument scaling #358 and position.

Change History

comment:1 Changed 12 years ago by Nick Draper

  • Priority changed from major to critical

comment:2 Changed 12 years ago by Nick Draper

  • Owner changed from Roman Tolchenov to Ronald Fowler
  • Description modified (diff)

contact name corrected and moved to Ron

comment:3 Changed 12 years ago by Ronald Fowler

(In [2185]) Initial reading and storing of position corrections and calculation of shifts (not yet stored) re #452

comment:4 Changed 12 years ago by Martyn Gigg

(In [2186]) Fix for template brackets under gcc. Re #452

comment:5 Changed 12 years ago by Ronald Fowler

(In [2191]) Fix some of the warnings/errors from last update of position correction re #452 LoadInstrumentFromRawTest.h now gets phi values from Raw file, hence sign change on X value.

comment:6 Changed 12 years ago by Ronald Fowler

(In [2287]) SetScalingPSD now scales detectors as well moving the position of them. Changed way scaling handled so that solid angles are correctly calculated for scaled objects. Re #452

comment:7 Changed 12 years ago by Ronald Fowler

(In [2288]) To speed testing added a small subset of the full scaling file for merlin. Test failed as this not checked in. Re #452

comment:8 Changed 12 years ago by Ronald Fowler

(In [2299]) Moved SetScalingPSD from Algorithms to DataHandling as needs to use the isisraw C code if a scaling file is not available. Will need include path change after this, but doing one thing at a time. Re #452

comment:9 Changed 12 years ago by Ronald Fowler

(In [2300]) Changes to include paths to complete the move of SetScalingPSD from Algorithm to DataHandling re #452

comment:10 Changed 12 years ago by Ronald Fowler

(In [2301]) Added reading of scaling information for PSDs from raw file. re #452

comment:11 Changed 11 years ago by Nick Draper

  • Milestone changed from Iteration 16 to Iteration 17

Batch move to Iteration 17

comment:12 Changed 11 years ago by Ronald Fowler

(In [2444]) Added proper check for monitors and expanded comments on PSD algorithm. Aslo report range of scaling values used in debug logging. re #452

comment:13 Changed 11 years ago by Ronald Fowler

(In [2446]) Fixed dOxygen warnings and added test of scaling from raw file. re #452

comment:14 Changed 11 years ago by Ronald Fowler

(In [2447]) Added scaling option to SetScalingPSD re #452

comment:15 Changed 11 years ago by Ronald Fowler

(In [2448]) Bug fix, gcc does not do max function. re #452

comment:16 Changed 11 years ago by Nick Draper

  • Status changed from new to closed
  • Resolution set to fixed

comment:17 Changed 11 years ago by Nick Draper

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:18 Changed 11 years ago by Nick Draper

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [2655]) closes #452 replace Merlin harcoded specific monitor test with a call to isMonitor. Also improved Doxygen Header

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1300

Note: See TracTickets for help on using tickets.