Ticket #4526 (closed: fixed)
Color Updates Fail
| Reported by: | Owen Arnold | Owned by: | Michael Reuter |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
Only seem to be able to set the color once then color changes are ignored.
- Load and run python script from here #4524
- Open Workspace using Simple Interface
- Change to scatter plot and change color ranges (from view menu). This works okay.
- Go back to Simple view mode and try to change color ranges in the same way. It is completely ignored. All subsequent changes are ignored.
Change History
comment:2 Changed 9 years ago by Michael Reuter
Refs #4526. Fixing issue with color options and switching views.
When the view got switched, the connections to the color options dialog box were no longer valid. The dialog box needs to be destroyed on view switch to assure that the connections are correct.
Changeset: b846d909740bf9276830f7ae30a049afabeef4c5
comment:3 Changed 9 years ago by Michael Reuter
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 9 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:5 Changed 9 years ago by Owen Arnold
- Status changed from verifying to closed
Fixed. It now works the way I expected it to.
comment:6 Changed 9 years ago by Michael Reuter
- Status changed from closed to reopened
- Resolution fixed deleted
A strange bug cropped up with this change that causes the program to crash on RHEL6 when I try to close the simple interface window after having used the color options dialog. I've since found a better way to do this.
comment:8 Changed 9 years ago by Michael Reuter
Refs #4526. Diconnecting dialogs rather than destroying.
I found that destroying the dialogs on view switch caused a bug on RHEL6. Therefore, I implemented a method by which the dialogs are disconnected and reconnected on view switch.
Changeset: f2bc7e79142da00c706c6d8364b3e08a2bd2ea87
comment:9 Changed 9 years ago by Michael Reuter
- Status changed from accepted to verify
- Resolution set to fixed
comment:11 Changed 9 years ago by Owen Arnold
- Status changed from verifying to reopened
- Resolution fixed deleted
Well the color changes still work as expected, but the SimpleVatesGUI has suddenly failed to shut down nicely in embedded mode on Windows. I just get a blank screen on the viewer and the application hangs. I can't provide any decent debugging information for this to pinpoint the exact cause, but it definitely appeared within the last 24 hours, so probably owing to f2bc7e79142da00c706c6d8364b3e08a2bd2ea87.
comment:13 Changed 9 years ago by Michael Reuter
- Status changed from accepted to verify
- Resolution set to fixed
The fix actually is working, the tester used the wrong updated version of MantidPlot. :-)
comment:14 Changed 9 years ago by Michael Reuter
Refs #4526. Fixing issue with color options and switching views.
When the view got switched, the connections to the color options dialog box were no longer valid. The dialog box needs to be destroyed on view switch to assure that the connections are correct.
Changeset: b846d909740bf9276830f7ae30a049afabeef4c5
comment:15 Changed 9 years ago by Michael Reuter
Refs #4526. Diconnecting dialogs rather than destroying.
I found that destroying the dialogs on view switch caused a bug on RHEL6. Therefore, I implemented a method by which the dialogs are disconnected and reconnected on view switch.
Changeset: f2bc7e79142da00c706c6d8364b3e08a2bd2ea87
comment:17 Changed 9 years ago by Owen Arnold
- Status changed from verifying to closed
This works as I expect it to. Color options dialog is remembering exact settings between views too.
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5373
