Ticket #4544 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

ThreadSafeLogStreamBuf is not thread safe when using ThreadPool

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Refs #4527 which triggered it.

ThreadSafeLogStreamBuf uses the PARALLEL_THREAD_NUMBER variable to determine the current thread. This only works with OpenMP, not with custom ThreadPool pthreads. So a fix is needed to make this truly thread safe.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

Refs #4544 truly thread-safe ThreadSafeLogStreamBuf

Changeset: a764ecc81294ec907070fe605181bc794e0b195e

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:5 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Examined the code and ran the unit tests

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5391

Note: See TracTickets for help on using tickets.