Ticket #4566 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Errors in inelastic diag

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Jon Taylor has tested diag and found sime minor issues:

  • Hard mask seems to be ignored
  • Diag doesn't respect 'diag_sample_zero' flag
  • It would be useful to print out the numbers of hard mask dets as well as the rest

so that the numbers all add up correctly

Change History

comment:1 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Martyn Gigg

Refs #4566. Address the issues raised with diag.

Changeset: b21a11af5254a8b18f173110e69080b467cd6cbb

comment:3 Changed 9 years ago by Martyn Gigg

Refs #4566. Update to diag system test.

Changeset: 0ebb20ce4f20320710a442d16c261c14baeecec8

comment:4 Changed 9 years ago by Martyn Gigg

Refs #4566. Disable parameter map checks for system test.

Changeset: 4a50f1a41a322bb25a8feeec1bfc2ea5c98cb5f9

comment:5 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:7 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

Spoke to Jon and he says that he thinks it is ok now.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5413

Note: See TracTickets for help on using tickets.