Ticket #4573 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Error bar colour does not match curve colour

Reported by: Martyn Gigg Owned by: Russell Taylor
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

From Rob Dalgliesh:

Plotting multiple curves with error bars on a single graph does not increment the error bar colour to match the curve colour, the errors are always black. They should match the curve colour.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Roman Tolchenov

comment:2 Changed 9 years ago by Roman Tolchenov

  • Status changed from assigned to accepted

comment:3 Changed 9 years ago by Roman Tolchenov

Re #4573. Use curve's pen to draw the errors

Changeset: 2850ba62f4e51e7b247e4aec77073335d700b2a7

comment:4 Changed 9 years ago by Russell Taylor

  • Owner changed from Roman Tolchenov to Russell Taylor

This breaks functionality added in #2657. I'll take this and do it properly.

comment:5 Changed 9 years ago by Russell Taylor

Revert "Re #4573. Use curve's pen to draw the errors"

This reverts commit 2850ba62f4e51e7b247e4aec77073335d700b2a7. Broke ability to customise error bars on Mantid curves (#2657.)

Changeset: 963d6c6ee14f97b0edfe49470aa35ae50760e141

comment:6 Changed 9 years ago by Roman Tolchenov

Re #4573. Use curve's pen to draw the errors

Changeset: 2850ba62f4e51e7b247e4aec77073335d700b2a7

comment:7 Changed 9 years ago by Russell Taylor

Revert "Re #4573. Use curve's pen to draw the errors"

This reverts commit 2850ba62f4e51e7b247e4aec77073335d700b2a7. Broke ability to customise error bars on Mantid curves (#2657.)

Changeset: 963d6c6ee14f97b0edfe49470aa35ae50760e141

comment:8 Changed 9 years ago by Russell Taylor

Error bars start out the same colour as the curve. Re #4573.

But can still be customised later if the user wishes.

Changeset: 7d9b3fd4f36a21beaa5082fd68b5fecc9fc375aa

comment:9 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

To test: Plot multiple curves from a workspace with errors (or add the errors later). They should have the same colour as the curve. Note that this only applies to plotting spectra from workspaces. Plotting from tables (or plotting bins) already had this behaviour.

comment:10 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

This does look like it is working fine.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5420

Note: See TracTickets for help on using tickets.