Conv Fit Error

[Peter Parker]

Franz Demmel has reported that the Conv fit has a problem displaying the end results, giving the following error:

Error in execution of algorithm CreateWorkspace:
DataX width must be as DataY or +1

EDIT:

Also, another error came up in conv fit after using abs corr:

Runtime error on line 12: “Matrixworkspace::getdetector(): no detectors for this workspace index. Search object” in file IndirectCommon.py at line 32

The abs corr is running fortran code and seems to produce a not conform workspace....

Fit started
Fit successful, Duration 0.12 seconds
PlotPeakByLogValue started
PlotPeakByLogValue successful, Duration 3.65 seconds
Unexpected exception: Workspace2D::getSpectrum, histogram number out of range

[Peter Parker]

Email from Spencer:

The first is a genuine error when using a reduced spectral range. The second was 'user error' - the routine assumes the WS/File name ends with _red & Franz did not have it.

So only first error is now a problem.

[Peter Parker]

Narrowed this down to using the settings as in the screenshot, but with a spectra range that is 39 or less. (I.e. 0 to 41, 1 to 41, 0 to 40 all work fine.)

CreateWorkspace (rightly) complains in this instance as it ends up being fed more x data values than y data values.

[Peter Parker]

Refs #4575 - Fix for conv fit.

Trim x axis data to correspond with y axis data before we pass it to create workspace.

Changeset: 0c5d955a961caf77eae43efd6c8e46af0b1a23a9

[Peter Parker]

Franz has indicated that he no longer gets the error since the fix.

To test:

• Set up the ConvFit tab of the IDA interface as in the screenshot, with the files attached.
• Use values for the spectra range that are not one of the following:
  • 0 - 41
  • 0 - 40
  • 1 - 41
• Click "Run Sequential Fit".

This should produce a plot without appending the following error to the results log:

Error in execution of algorithm CreateWorkspace:
DataX width must be as DataY or +1

[Vickie Lynch]

Followed testing instructions and there was no error in the results log

[Stuart Campbell]

This ticket has been transferred to github issue ​5422