Ticket #4590 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

An empty string selected from list on GUI does not change default property value

Reported by: Alex Buts Owned by: Alex Buts
Priority: critical Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

If some property selects its value from a list and the list contains empty string, choosing this value from the GUI do not resets default value.

Python interface works.

e.g: ConvertToMDEvents algorithm: Has property QDimensions, with possible values "",|Q| and QhQkQl. |Q| -- default value. Trying to select "" from gui results in |Q| Setting value QDimensions="" from python works

Change History

comment:1 Changed 9 years ago by Alex Buts

I am actually changing QDimensions to have "" as default as algorithm is not usable otherwise.

But other property: dEAnalysisMode has similar behaviour -- you will never select "" from GUI

Tested on Win and Unix

comment:2 Changed 9 years ago by Alex Buts

refs #4572 changes to default values caused by bug ref #4590

Allows to use algorithm from GUI until the bug is fixed.

Changeset: 089842d0f704cd32062709ea618a917b0171aa58

comment:3 Changed 9 years ago by Alex Buts

  • Summary changed from An ampty string selected from list on GUI does not change default property value to An empty string selected from list on GUI does not change default property value

comment:4 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Alex Buts

comment:5 Changed 9 years ago by Alex Buts

  • Status changed from assigned to accepted

comment:6 Changed 9 years ago by Alex Buts

refs #4590 Made ConvertToMDEvents not have empty string

As empty string entered in GUI by definition sets property value to default, the bug is actually a feature. It is better to not to have empty string properties in ConvertToMDEvents algorithm.

Changeset: 11d0163298539a309917daf3ee242da5ab259be3

comment:7 Changed 9 years ago by Alex Buts

Apparently, there is the code feature: an empty string set from GUI resets the property to default value, while empty string set from python clears the string value.

After discussion with Martin decided that it is desirable behaviour.

A description of this feature has been added to the wiki page, describing Mantid properties.

ConvertToMDEvents code and wiki modified to avoid meaningful empty property strings.

comment:8 Changed 9 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 9 years ago by Alex Buts

refs #4590 Made ConvertToMDEvents not have empty string

As empty string entered in GUI by definition sets property value to default, the bug is actually a feature. It is better to not to have empty string properties in ConvertToMDEvents algorithm.

Changeset: 11d0163298539a309917daf3ee242da5ab259be3

comment:10 Changed 9 years ago by Alex Buts

refs #4590 properties description in code made consistent with WIKI

Changeset: 682b9a4962f8ff3e5975920d80149cf601dc0853

comment:11 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:12 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5437

Note: See TracTickets for help on using tickets.