Ticket #4614 (closed: fixed)
SlicingAlgorithm: adapt to read comma-separated dimension names or IDs
| Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | owen.arnold@…, alex.buts@… | Blocked By: | |
| Blocking: | Tester: | Owen Arnold |
Description
In the dimension parameters:
- Accept either dimension ID or dimension name
- Consider dimension names that go [x,y,z] to be a block so as to not break comma-sep.
- Possibly display dimension ID in AlgorithmDock and SliceViewer.
Attachments
Change History
comment:2 Changed 9 years ago by Janik Zikovsky
Refs #4614 renamed member variables with m_XXX convention
Changeset: 4c8cf4cd5529306e19d85da5f0010ecd794dcefc
comment:3 Changed 9 years ago by Janik Zikovsky
Refs #4614 renamed member variables with m_XXX convention
Changeset: 8f115c5781f285eae3e64205e20f9bfeeca4d6ab
comment:4 Changed 9 years ago by Janik Zikovsky
Refs #4614 accept dimension names with commas in SlicingAlgorithms
Like BinMD and SliceMD.
Changeset: 60accaa75a1d0896656b24b276cbea87384c3de7
comment:5 Changed 9 years ago by Janik Zikovsky
Refs #4614 show dimension ID in mantid dock
Changeset: aaa5766e18e4eb9a4b66ad4879e691f8fa413e23
comment:6 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
comment:7 Changed 9 years ago by Janik Zikovsky
Refs #4614 renamed member variables with m_XXX convention
Changeset: 4c8cf4cd5529306e19d85da5f0010ecd794dcefc
comment:8 Changed 9 years ago by Janik Zikovsky
Refs #4614 renamed member variables with m_XXX convention
Changeset: 8f115c5781f285eae3e64205e20f9bfeeca4d6ab
comment:9 Changed 9 years ago by Janik Zikovsky
Refs #4614 accept dimension names with commas in SlicingAlgorithms
Like BinMD and SliceMD.
Changeset: 60accaa75a1d0896656b24b276cbea87384c3de7
comment:10 Changed 9 years ago by Janik Zikovsky
Refs #4614 show dimension ID in mantid dock
Changeset: aaa5766e18e4eb9a4b66ad4879e691f8fa413e23
comment:11 Changed 9 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:12 Changed 9 years ago by Owen Arnold
The first and second points made in the ticket header now work.
The last point, doesn't. According to aaa5766e18e4eb9a4b66ad4879e691f8fa413e23 I should see the dimension id if it's different from the name. But something isn't working here.....
comment:13 Changed 9 years ago by Owen Arnold
See SliceMDIssue.py for example of this not working. Expand the properties of the md workspaces and the ids are never shown.
comment:14 Changed 9 years ago by Janik Zikovsky
Refs #4614: error was due to copy/pasted code!
Changeset: 9957b56793f0c259384d49ba0da96edb3108dbca
comment:15 Changed 9 years ago by Janik Zikovsky
Point number 3 should work now.
comment:16 Changed 9 years ago by Owen Arnold
- Status changed from verifying to closed
Re-ran the SliceMDIssue.py script and now find that the dimension id is being provided. Fixes point number 3.
comment:17 Changed 7 years ago by Alex Buts
refs #4614 here the changes brought back again
Changeset: b50f279be194683814920e1e5ffa8f08e6c24334
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5461
