Change MWRunFiles to Disallow Mutilple Files by Default

[Peter Parker]

Hi all

Just a quick heads up about an upcoming change I’ll be making to the MWRunFiles class.

Currently, a user navigating to a file via the “Browse” button sees that file *appended* to the text field, rather than seeing it replace what is there already. This seems fine in places where multiple runs are supported and so might be expected, but there are places where it only makes sense to have a single run. In these cases reusing the widget can produce unexpected results, or at the very least force the user to clear the field each and every time they want to use it.

With this is mind, I will be turning the “append” functionality off by default; developers wanting to use it specifically for their interfaces can use the allowMultipleFiles(bool) function to turn it back on where it is needed.

Regards

P

[Peter Parker]

Refs #4622 - appending files now off by default.

Changeset: 1b8eb7bec800033ac290332a8db75b708e6c2f18

[Peter Parker]

Files are still appended in cases where the multiple files option has been turned on specifically.

[Peter Parker]

Refs #4622 - Files are never appended. Multi files still supported.

Changeset: c0f743bd59eaca7c7958f036ad3e16d6843188a8

[Peter Parker]

The decision was made to stop the appending functionality altogether.

To test:

• Find where a MWRunFiles widget is used and check that repeatedly using the browse button no longer appends files in a comma separated list. For example the "Run Files" field of the Energy Tranfer tab on the Convert to Energy interface.

• Find where a MWRunFiles widget is used that has "multi file" usage enabled, and check that you can still select multiple files, but that repeated use of the browse button no longer appends files. For example the "Run No" field of the Calibration tab on the same interface.

[Peter Parker]

Refs #4622 - Change multi file setting of a MWRunFiles widget.

Previously this was set to true by default, but since default behaviour has been switched to false, multi file support was lost for the "Run Files" field of the Energy Tranfer tab of the CTE interface. Changed the multi file property to true for this widget so multiple files can be run.

Changeset: da14aa4c23d528c8dffecdc28c1e6b3f39e47d06

[Stuart Campbell]

The behaviour seems to be if I select multiple files on a single 'browse...' then I get multiple filenames in the filename box. If I use multiple 'browse' then I only get the last file browsed to.

I think this is the intended behaviour.

[Stuart Campbell]

This ticket has been transferred to github issue ​5469