Ticket #4630 (closed: fixed)
Binary operation on workspace group can fail to group the output
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | owen.arnold@… | Blocked By: | |
| Blocking: | Tester: | Janik Zikovsky |
Description (last modified by Russell Taylor) (diff)
This happens if the output workspace already exists. The cause is a piece of code in BinaryOperation.cpp that deletes the output workspace in advance of running the algorithm if it can see that it will be replaced. In the case of a group the group itself is deleted when its last member goes and the group handling does not foresee this.
I will comment out the code that does the deletion and create a follow up ticket for the next iteration to look for an alternative solution. The cost is a potential temporary swelling of memory use if overwriting a workspace in a binary operation.
Attachments
Change History
Changed 9 years ago by Russell Taylor
- Attachment group-operations.py added
A script that demonstrates the problem
comment:4 Changed 9 years ago by Russell Taylor
Comment out deletion of pre-existing output workspace. Re #4630.
It can cause problems with workspace groups.
Changeset: 7384701074b43cb50577e8de17197c014da0b6c6
comment:5 Changed 9 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 9 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
