CorrectKiKf crashes for BASIS files

[Stuart Campbell]

If you run the Convert To Energy GUI, select BASIS and try and process a NeXus (I was using an event NeXus file). Then you get the following error:

CorrectKiKf-[Notice] CorrectKiKf started
CorrectKiKf-[Information] Algorithm: CorrectKiKf v1
CorrectKiKf-[Information] Parameters:
CorrectKiKf-[Information]   Name: InputWorkspace, Value: BSS_16715_event, Default?: No, Direction: Input
CorrectKiKf-[Information]   Name: OutputWorkspace, Value: BSS_16715_event, Default?: No, Direction: Output
CorrectKiKf-[Information]   Name: EMode, Value: Indirect, Default?: No, Direction: Input
CorrectKiKf-[Information]   Name: EFixed, Value: 8.9884656743115785e+307, Default?: Yes, Direction: Input
CorrectKiKf-[Information] Processing event workspace
CorrectKiKf-[Debug] 1366 Ef: 2.08223 (from parameter file)
CorrectKiKf-[Information] 0 Ef: 2.082 (from parameter file)
CorrectKiKf-[Debug] 12977 Ef: 2.08229 (from parameter file)
CorrectKiKf-[Debug] 8879 Ef: 2.08187 (from parameter file)
CorrectKiKf-[Debug] 683 Ef: 2.08194 (from parameter file)
CorrectKiKf-[Debug] Ef not found for spectrum 8196
CorrectKiKf-[Debug] 15026 Ef: 2.08229 (from parameter file)
CorrectKiKf-[Debug] 7513 Ef: 2.08202 (from parameter file)
CorrectKiKf-[Debug] 10928 Ef: 2.08186 (from parameter file)
CorrectKiKf-[Debug] Ef not found for spectrum 12294
CorrectKiKf-[Debug] Ef not found for spectrum 14343
CorrectKiKf-[Error] 5464 Ef: 2.08201 (from parameter file)
CorrectKiKf-[Debug] 10245 Ef: 2.08231 (from parameter file)
CorrectKiKf-[Debug] 6147 Ef: 2.082 (from parameter file)
CorrectKiKf-[Debug] 9562 Ef: 2.08219 (from parameter file)
CorrectKiKf-[Error] 3415 Ef: 2.08222 (from parameter file)
CorrectKiKf-[Error] 4098 Ef: 2.082 (from parameter file)
CorrectKiKf-[Error] 13660 Ef: 2.08207 (from parameter file)
CorrectKiKf-[Error] 1 Ef: 2.082 (from parameter file)
CorrectKiKf-[Error] 1367 Ef: 2.08222 (from parameter file)
CorrectKiKf-[Error] 8880 Ef: 2.08186 (from parameter file)
CorrectKiKf-[Error] 6830 Ef: 2.08227 (from parameter file)
CorrectKiKf-[Error] 11611 Ef: 2.08218 (from parameter file)
CorrectKiKf-[Error] 15709 Ef: 2.08208 (from parameter file)
CorrectKiKf-[Debug] 2732 Ef: 2.08193 (from parameter file)
CorrectKiKf-[Error] 684 Ef: 2.08193 (from parameter file)
CorrectKiKf-[Error] 4781 Ef: 2.08226 (from parameter file)
CorrectKiKf-[Error] 15027 Ef: 2.0823 (from parameter file)
CorrectKiKf-[Error] CorrectKiKf: No Ef value has been set or found.
CorrectKiKf-[Error] 2049 Ef: 2.082 (from parameter file)
CorrectKiKf-[Error] 12978 Ef: 2.08229 (from parameter file)
CorrectKiKf-[Debug] Exception thrown in parallel region
CorrectKiKf-[Error] Error in execution of algorithm CorrectKiKf:
CorrectKiKf-[Error] CorrectKiKf: error (see log)

[Stuart Campbell]

Only seems to be a problem for newer files. I was testing using BSS_16715_event.nxs.

[Stuart Campbell]

Added Efixed values for new banks. refs #4633

Corrected the default Ef. Added a default Ef for banks 3 and 4.

Changeset: 5bed4a47ceb14081aeaa9f174bc0d6d253c313bb

[Stuart Campbell]

Changed to getting the Ef recursively. refs #4633

Now get the Efixed recursively, so that we get the default value from the bank for the pixels that can't be reached.

Changeset: 1e8b0eca8b2a46947bccd8b46e6454cce69ff9ee

[Stuart Campbell]

This ticket has been transferred to github issue ​5480