Ticket #4647 (closed: fixed)
Algorithm's default ProcessGroups does not work with 2 inputs
Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
---|---|---|---|
Priority: | major | Milestone: | Release 2.1 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Russell Taylor |
Description (last modified by Janik Zikovsky) (diff)
If your algorithm does NOT inherit from PairedGroupAlgorithm, and gets these inputs: Input1 : groupA Input2 : groupB It is processed like this: Input1 : A1 Input2 : A1 then Input1 : A2 Input2 : A2
For example, try IntegratePeaksMD with two groups.
- Also, I expect that the code would die if one of the inputs were an Optional WorkspaceProperty.
Take the behavior of PairedGroupAlgorithm, generalize it to N input workspaces, and use it for default Algorithm behavior.
Change History
comment:3 Changed 9 years ago by Janik Zikovsky
Refs #4647 start of a unified processGroups
Changeset: 73472384322373e99dca9d1deac8fc2b17d59447
comment:4 Changed 9 years ago by Janik Zikovsky
Refs #4647 code for processGroups, not currently used
Changeset: 72fbbfe3842fded20365951d13c53a8001367847
comment:5 Changed 9 years ago by Janik Zikovsky
Refs #4647 #4625 merging Algorithm.cpp
Changeset: f9c4d96583556048e70011cb310d8c8b802a4435
comment:6 Changed 9 years ago by Janik Zikovsky
Refs #4647 #996: clean up a lot of group code.
4 tests fail at this point
Changeset: c9c9e0f4113e2a2b9b629df8e6614fe38f552d12
comment:7 Changed 9 years ago by Janik Zikovsky
Refs #4647 fix tests, handle groups of size 1
Changeset: 1cadfc8fa0128e555be7c50ccba1a21c4699bd89
comment:8 Changed 9 years ago by Janik Zikovsky
Still to do: get rid of PairedGroupAlgorithm, which is now empty
comment:9 Changed 9 years ago by Janik Zikovsky
Refs #4647 Removed PairedGroupAlgorithm
Changeset: 919148773d8f845bc0eac412199d41454be7b253
comment:10 Changed 9 years ago by Janik Zikovsky
TODO: This broke RenameWorkspace for group workspaces. But there is no test (of course) so it was not caught.
comment:11 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
Russell is working on RenameWorkspace.
comment:12 Changed 9 years ago by Mathieu Doucet
Re #4647 fix warnings
Changeset: fcb780bc57613794710bb6f3211b7d19babdef6c
comment:13 Changed 8 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5494