Ticket #4657 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Extend IntegratePeakTimeSlices for panels that may not be Rectangular Detectors

Reported by: Ruth Mikkelson Owned by: Ruth Mikkelson
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

The current implementation only works with Rectangular Detectors. The detectors(pixels) close to a peak should be about rectangular in order for the results to be relevant.

Change History

comment:1 Changed 9 years ago by Ruth Mikkelson

  • Status changed from new to accepted
  • Owner set to Ruth Mikkelson

comment:2 Changed 9 years ago by Ruth Mikkelson

Found nearest neighbors by checking children of Bank

Refs #4657

Changeset: a4e94a169a09ba1e9a2abcf3382aa78737ac747d

comment:3 Changed 9 years ago by Ruth Mikkelson

Resolved conflicts in a strange merge I hope. Refs #4657

Merge branch 'master' into Work1

Conflicts:

Code/Mantid/Framework/CurveFitting/inc/MantidCurveFitting/BivariateNormal.h Code/Mantid/Framework/CurveFitting/src/BivariateNormal.cpp Code/Mantid/Framework/CurveFitting/test/BivariateNormalTest.h

Changeset: 555a873d983a1bbce78d0c450db3084f0f091d60

comment:4 Changed 9 years ago by Ruth Mikkelson

Redid changes by others lost during merge.

Refs #4657

Changeset: dede7bd606d2ad3e962ea231c768eaae4294ff6b

comment:5 Changed 9 years ago by Ruth Mikkelson

Added virtual to the destructor for IntegratePeakTimeSlices.

Refs #4657

Changeset: 10f07dea840476da9be8553b00ece7c1e1f0680d

comment:6 Changed 9 years ago by Ruth Mikkelson

Fixed Windows error by adding const

Refs #4657

Changeset: d6ea0422d584140c6e66616a372ce4d9d22a7fd7

comment:7 Changed 9 years ago by Janik Zikovsky

Refs #4657 make Peak object find grandparent as bank name

in all cases, not just rectangular detectors

Changeset: ac363628e4fafc7e0cca350ef5b5051cf82a0d0e

comment:8 Changed 9 years ago by Janik Zikovsky

Refs #4657 give more helpful names to wish panels in IDF

Changeset: 7dbd18a32ed85a5650b1d6ce8a70b2a6db544530

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #4657: Peak object finds row/column from the names of its parents

Changeset: b3404050efec7250a9c7c0dde64fe4e4971476ad

comment:10 Changed 9 years ago by Janik Zikovsky

Refs #4657 strings include

Changeset: 4bcf63adf1e99ef7b48ac22a80ee1566e8d45c92

comment:11 Changed 9 years ago by Janik Zikovsky

Refs #4657 make peak row/col work

Changeset: 8124653589926ba07143475f0b170874612f732b

comment:12 Changed 9 years ago by Ruth Mikkelson

Updated to work with WISH data.

Refs #4657.

Changeset: 0077296f60f9ee0e65a07fd6f1437ca1fa49edec

comment:13 Changed 9 years ago by Ruth Mikkelson

Eliminated a Compiler warning.

Refs #4657

Changeset: 8405c6459bebda85fb303fef2902a2b1f9284c5a

comment:14 Changed 9 years ago by Ruth Mikkelson

Eliminated one compiler check note, added array bounds check

Refs #4657

Changeset: 82c4ad27e80863fae173469c092c8a8d1a6114d1

comment:15 Changed 9 years ago by Ruth Mikkelson

Refs #4657. Reverted old so no merge conflicts

cannot resolve conflict with too large of file. AutoTestData/SEQ_MWDEWs.nxs(?)

Changeset: c76d96ce7120e2356982de610a6105b7a61814dd

comment:16 Changed 9 years ago by Ruth Mikkelson

Updated to work with WISH data.

Refs #4657.

Changeset: 0077296f60f9ee0e65a07fd6f1437ca1fa49edec

comment:17 Changed 9 years ago by Ruth Mikkelson

Eliminated a Compiler warning.

Refs #4657

Changeset: 8405c6459bebda85fb303fef2902a2b1f9284c5a

comment:18 Changed 9 years ago by Ruth Mikkelson

Update Wiki documentation and parameter documentation.

Refs #4657

Changeset: 943e71063a62fccb766cd0824987cf3b5b06571b

comment:19 Changed 9 years ago by Janik Zikovsky

Refs #4657 give more helpful names to wish panels in IDF (cherry picked from commit 7dbd18a32ed85a5650b1d6ce8a70b2a6db544530)

Changeset: 17a75ec393db7a194264a82b330909593c03a411

comment:20 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:21 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:22 Changed 8 years ago by Vickie Lynch

How do I get the BankName, Row, and Col in a peaksworkspace for WISH? I loaded WISH00017986 and found 100 peaks using FindPeaksMD, but get "Cannot get panel for a peak".

comment:23 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to closed

Integrated WISH00017986 and got reasonable values of Intensity and SigInt for some of the peaks.

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5504

Note: See TracTickets for help on using tickets.