Ticket #4660 (closed: wontfix)

Opened 9 years ago

Last modified 5 years ago

[IDA] ConvFit - Fix error thrown while using this tab after applying corrections.

Reported by: Peter Parker Owned by: Peter Parker
Priority: critical Milestone: Release 3.1
Component: MantidPlot Keywords: IDA
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description (last modified by Peter Parker) (diff)

From Franz:

The error occurs when I am running the abs corrected file, created from abs correction tab (attached with the resolution file) in conv fit with 1 Lorz + el line.

Also it writes out the data again into an “osi95111_graphite_conv” file without the “correct”

The abs corr is running fortran code and seems to produce a not conform workspace....

The error:

Runtime error on line 12: “Matrixworkspace::getdetector(): no detectors for this workspace index. 
Search object” in file IndirectCommon.py at line 32
Fit started
Fit successful, Duration 0.12 seconds
PlotPeakByLogValue started
PlotPeakByLogValue successful, Duration 3.65 seconds
Unexpected exception: Workspace2D::getSpectrum, histogram number out of range

Attachments

osi95091_graphite002_res.nxs (195.8 KB) - added by Peter Parker 9 years ago.
osi95111_graphite002_Correct_95157.nxs (911.2 KB) - added by Peter Parker 9 years ago.

Change History

Changed 9 years ago by Peter Parker

Changed 9 years ago by Peter Parker

comment:1 Changed 9 years ago by Peter Parker

  • type changed from enhancement to defect

comment:2 Changed 9 years ago by Nick Draper

  • Owner set to Peter Parker
  • Status changed from new to assigned

comment:3 Changed 9 years ago by Peter Parker

Spencer has suggested that this probably has to do with the instrument file not being loaded before carrying out the step that produces the attached files.

Awaiting feedback from user to see if opening the CTE interface and then running the corrections again produces workspaces with valid detector info.

comment:4 Changed 9 years ago by Peter Parker

  • Status changed from assigned to accepted

comment:5 Changed 9 years ago by Peter Parker

  • Milestone changed from Iteration 32 to Iteration 33

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:7 Changed 8 years ago by Peter Parker

A more recent results log output is as follows:

RuntimeError: MatrixWorkspace::getDetector(): No detectors for this workspace index. search object 
  at line 12 in '<Interface>'
  caused by line 110 in 'C:/MantidInstall/scripts/Inelastic\IndirectDataAnalysis.py'
  caused by line 48 in 'C:/MantidInstall/scripts/Inelastic\IndirectDataAnalysis.py'
  caused by line 84 in 'C:/MantidInstall/scripts/Inelastic\IndirectCommon.py'

It seems the corrected workspaces coming out of CalcCorr do not contain detector info, and this is causing problems.

Two possible workarounds:

  1. Produce conforming workspaces in CalcCorr.
  2. Get detector information straight from the instrument.

The latter is probably the easiest, but wont solve the core issue, which is we are producing non-conform workspaces. These workspaces wont work elsewhere (like in SofQW) either.

Last edited 8 years ago by Peter Parker (previous) (diff)

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:9 Changed 8 years ago by Peter Parker

  • Priority changed from major to critical

comment:10 Changed 8 years ago by Peter Parker

  • Summary changed from Fix error thrown while using ConvFit after abs correction. to [IDA] ConvFit - Fix error thrown while using this tab after applying corrections.

comment:11 Changed 8 years ago by Peter Parker

  • Keywords IDA added

comment:12 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

moved to Release 2.4

comment:13 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:14 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:15 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:16 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:17 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after R2.6

comment:18 Changed 7 years ago by Peter Parker

  • Status changed from new to verify
  • Resolution set to wontfix
  • Description modified (diff)

This works fine for me now, by using the attached files as well as generating a new one from the calculate corrections tab.

It has obviously been fixed elsewhere. Closing.

comment:19 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:20 Changed 7 years ago by Peter Parker

  • Milestone changed from Backlog to Release 3.1

comment:21 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

I tried this with both the files provided and some more recent files walked through CalCor. It does indeed appear that whatever was causing the issue has now been fixed.

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5507

Note: See TracTickets for help on using tickets.