Ticket #4662 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LoadEventNexus: handle multiple preprocessors

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: blocker Milestone: Release 2.0
Component: Mantid Keywords:
Cc: pf9@… Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Janik Zikovsky) (diff)

Example: ARCS_12954 at /SNS/ARCS/shared/NeXusFiles/ARCS/IPTS-4041/0/12954/NeXus/ARCS_12954_event.nxs

  • ARCS has 2 preprocessors. Half the banks are in one, half in the other
  • Each preprocessor has its own pulse time list.
  • Each pulse time list is NOT guaranteed to be the same.
  • The "event_time_zero" field of each bank is the correct pulse time FOR THIS BANK only.
  • We don't want to load event_time_zero once per bank (110 banks in ARCS!)
  • So the solution proposed is:
    • Add a field in the IDF for each instrument for each bank indicating which preprocessor is in use (just an int, 0, 1, etc.).
    • When loading, use that information to determine if you need to load the "event_time_zero" field
    • Load "event_time_zero" field once per preprocessor (not per bank)
  • This solution will handle old files as well.

New solution:

  • For each bank, check the attributes of "event_time_zero"
  • If the start time and the length are the same, then we consider those to be from a single preprocessor
  • Load each event_time_zero only once per file.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Priority changed from major to blocker
  • Status changed from new to accepted
  • Description modified (diff)
  • Milestone changed from Iteration 33 to Iteration 32

comment:2 Changed 9 years ago by Janik Zikovsky

Refs #4662: handle different pulse times for different banks

Right now, we are checking using the length/start time of each bank. When Jim does his thing, we will have a unique id number to use instead. Jim will also fix the startTime of each event_time_zero field.

Changeset: 00eb3f219222a7c73575a16af30633cc8f746bf6

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4662 fix unit test

Changeset: 58ce5719c6110e764ffbe245ab852f72517df6c7

comment:4 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Resolving as fixed for now. When Jim updates the translation service we will need to use the preprocessor attribute. This will be a new ticket.

comment:5 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to closed

FilterBadPulses semms reasonable

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5509

Note: See TracTickets for help on using tickets.