Ticket #4674 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

ICat Login Progress

Reported by: Owen Arnold Owned by: Jay Rainey
Priority: major Milestone: Release 3.0
Component: Framework Keywords: ICAT
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Jay Rainey) (diff)

When I click 'Basic Search' in ICat It can take quite some time to get to the point where I'm prompted for a login. I get no feedback from the gui during this process.

I understand that It might be difficult to extract real progress information as part of this process, but as far as I (and other users) may be concerned, nothing is happening.

At the very least we should set the progress at 50% until the algorithm(s) complete(s).

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:6 Changed 7 years ago by Nick Draper

  • Keywords ICAT added

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:9 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Jay Rainey
  • Milestone changed from Backlog to Release 3.0

comment:10 Changed 7 years ago by Jay Rainey

  • Status changed from new to inprogress

Sets progress bar to 50%. Refs #4674.

Changeset: feadcdc73a465665241f5fd5c26d4e61862086a6

comment:11 Changed 7 years ago by Jay Rainey

  • Description modified (diff)

I output a message to inform the user of what's going on, as well as added a progress bar. To test:

Before obtaining changes

  1. Open Mantid
  2. Click Catalog -> Login (Located in the top menu bar).
  3. User isn't informed on what's going on.

After changes

  1. Open Mantid
  2. Click Catalog -> Login (Located in the top menu bar).
  3. Message output to inform user of what is happening (verification of details).
  4. Progress bar visually shows them that something is happening in the background.

Verify that the message is correct, and informs the user of what's happening.

Last edited 7 years ago by Jay Rainey (previous) (diff)

comment:12 Changed 7 years ago by Jay Rainey

Sets progress bar to 50%. Refs #4674.

Changeset: feadcdc73a465665241f5fd5c26d4e61862086a6

comment:13 Changed 7 years ago by Jay Rainey

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:14 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:15 follow-up: ↓ 17 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The Algorithm::progress method has an optional second argument that is a string to overlay on the progress bar. You should add the message there as well.

N.B. On choosing several of the options from the Catalog menu I see messages like the following on the console: 

Object::connect: No such slot ApplicationWindow::writeErrorToLogWindow(const QString&)
Object::connect:  (sender name:   'ICatSearch'

comment:16 Changed 7 years ago by Jay Rainey

  • Status changed from reopened to inprogress

Added text to the progress bar. Refs #4674.

Changeset: 995510bf181cb6b8ca304e984e00612fa38b7135

comment:17 in reply to: ↑ 15 Changed 7 years ago by Jay Rainey

Replying to Russell Taylor:

The Algorithm::progress method has an optional second argument that is a string to overlay on the progress bar. You should add the message there as well.

Fixed. See comment:16

N.B. On choosing several of the options from the Catalog menu I see messages like the following on the console: 

Object::connect: No such slot ApplicationWindow::writeErrorToLogWindow(const QString&)
Object::connect:  (sender name:   'ICatSearch'

I've created a new ticket for this: #7886 as error handling needs improved in general.

comment:18 Changed 7 years ago by Jay Rainey

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:19 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying

comment:20 follow-up: ↓ 21 Changed 7 years ago by Russell Taylor

This can't be tested until the up-to-date version of the topic branch is pushed up to github. The last commit (​https://github.com/mantidproject/mantid/commit/995510bf181cb6b8ca304e984e00612fa38b7135) currently shows as only existing in the develop branch.

comment:21 in reply to: ↑ 20 Changed 7 years ago by Jay Rainey

Replying to Russell Taylor:

My mistake. I've now ​published it ready for testing.

Last edited 7 years ago by Jay Rainey (previous) (diff)

comment:22 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/4674_icat_login_progress_bar'

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5521

Note: See TracTickets for help on using tickets.