Ticket #4683 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Rebin2D has edge effects

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Jon has reported that Rebin2D can give edge effects, see attached image.

Attachments

Rebin2D.png (86.9 KB) - added by Martyn Gigg 9 years ago.

Change History

Changed 9 years ago by Martyn Gigg

comment:1 Changed 9 years ago by Martyn Gigg

Refs #4202 Refs #4683. Merge much of code for Rebin2D & SofQW2

This solves the edge effect issue for Rebin2D and SofQW2 should now be correctly normalised.

Changeset: 2f0168eab509c268f14619879083701331bfb57d

comment:2 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:5 Changed 9 years ago by Martyn Gigg

Refs #4683. Fix issue with edges effects in Rebin2D

Some intersections were being missed out because the Laszlo algorithm thinks a polygon completely inside another polygon has no intersection. It has been modified to return the whole (smaller) polygon in this case.

Changeset: e81069314f82d2ce535b7c382a268361432b351c

comment:6 Changed 9 years ago by Martyn Gigg

Refs #4683. Fix a problem with the quadrilateral copy ctor

Changeset: 0af222480d31ae0a78080b98312768e1e51e560f

comment:7 Changed 9 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:10 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Rebinned with various parameters to produce coarse/fine output. Cannot reproduce these edge effects now.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5530

Note: See TracTickets for help on using tickets.