Ticket #4702 (closed: duplicate)

Opened 9 years ago

Last modified 5 years ago

Check needed for invalid input in UnitCell

Reported by: Ronald Fowler Owned by: Andrei Savici
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Robert Whitley

Description

Ticket #4679 showed that a segfault occurs in UnitCell using certain values for cell angles. It was shown that values were not physical and hence the algorithm cannot be expected to process them successfully.

UnitCell::recalculate should check the angle condtions listed in #4679 and throw a suitable exception if the input is not physical to avoid generating a segmentation fault. Good practice would also be to check all inversion operations for success in case of unexpected user input.

If the angles are close to non-physical values a warning message may be useful.

Change History

comment:1 Changed 9 years ago by Andrei Savici

  • Status changed from new to assigned
  • Owner changed from Anyone to Andrei Savici

comment:2 Changed 9 years ago by Andrei Savici

  • Status changed from assigned to accepted

Fixed in #4708

comment:3 Changed 9 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to duplicate

comment:4 Changed 8 years ago by Robert Whitley

  • Status changed from verify to verifying
  • Tester set to Robert Whitley

comment:5 Changed 8 years ago by Robert Whitley

  • Status changed from verifying to closed

Confirmed as duplicate.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5549

Note: See TracTickets for help on using tickets.