Ticket #4705 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

[IDA] - CubicFit and MSDFit changes

Reported by: Peter Parker Owned by: Peter Parker
Priority: major Milestone: Release 2.0
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Pushing Spencer's changes:

  1. Routine CubicFit. Changed the fit function from

function = 'name=UserFunction, Formula=A0+A1*x+A2*x*x, A0=1, A1=0, A2=0'

to

function = 'name=Quadratic, A0=1, A1=0, A2=0'

  1. Routine MSDFit. Changed the fit routine from

fit_alg = Linear(lnWS, outWS, WorkspaceIndex=0, StartX=startX, EndX=endX)

to

function = 'name=LinearBackground, A0=0, A1=0' fit_alg = Fit(lnWS, 0, startX, endX, function, Output=outWS)

in order to get rid of deprecated Linear. Also, modified WS names & plotting.

Change History

comment:1 Changed 9 years ago by Peter Parker

Refs #4705 - Push Spencer's changes.

Changeset: fb975feac245e28435b4965da66a762cbaa0d65c

comment:2 Changed 9 years ago by Peter Parker

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:5 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

The code changes seem to reflect what was intended.

comment:6 Changed 9 years ago by Peter Parker

  • Status changed from closed to reopened
  • Resolution fixed deleted

Sorry to reopen another one you've tested Stuart, but Spencer has more code to commit.

comment:7 Changed 9 years ago by Peter Parker

Refs #4705 - More IDA and IAC code from Spencer.

Changeset: dd433147aa7135c8d14c5f249972084fc5a68700

comment:8 Changed 9 years ago by Peter Parker

  • Status changed from reopened to accepted

comment:9 Changed 9 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying

comment:11 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

Well if Spencer's happy then who am i to argue! :-)

Played with IDA using a random IRIS run - all seems well.

comment:12 Changed 9 years ago by Peter Parker

Refs #4705 - More IDA and IAC code from Spencer.

Changeset: dd433147aa7135c8d14c5f249972084fc5a68700

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5552

Note: See TracTickets for help on using tickets.